Frans de Jonge
9fb7801974
[fix] ConfigMenu cre margins hold action ( #4702 )
...
See https://github.com/koreader/koreader/pull/4691#issuecomment-468905263
2019-03-02 12:14:36 +01:00
Frans de Jonge
d8845f8589
[fix] GestureDetector: only initiate multiswipe with clear N/S/E/W direction ( #4698 )
...
Accidentally lost while refacturing. See <https://github.com/koreader/koreader/pull/4640#issuecomment-468788986 >.
2019-03-01 21:47:45 +01:00
Frans de Jonge
3aa5ebb1df
[fix] Gesture manager: most defaults should be reader-only
2019-03-01 17:01:08 +01:00
Frans de Jonge
8a1c0f6bd4
[UX] Gesture manager: add default previous/next chapter gesture
...
* Up, down, up for previous.
* Dow, up, down for next.
2019-03-01 17:01:08 +01:00
Frans de Jonge
ba4bf7243d
[chore] Deprecate TapForward/TapBackward ( #4689 )
...
Also fix previous page action in gesture manager.
2019-03-01 16:05:03 +01:00
Frans de Jonge
1d1dc74290
[UX] creoptions: add more margin values
...
Fixes #4684 .
2019-03-01 15:26:25 +01:00
poire-z
1e4469fec2
[UX] Gesture manager: add actions - prev/next chapter ( #4692 )
...
Also adds rudimentary support for these in ReaderPaging.
2019-03-01 14:54:38 +01:00
Frans de Jonge
1475acdae7
[UX] Gesture manager: add action - go to ( #4690 )
...
Cf. <https://github.com/koreader/koreader/issues/4687 >.
2019-03-01 12:59:39 +01:00
Frans de Jonge
332fa642e3
[UX] Gesture manager: add action - toggle reflow ( #4688 )
...
Cf. https://github.com/koreader/koreader/issues/4687
2019-03-01 10:38:29 +01:00
Frans de Jonge
4547b2d65f
[fix] GestureDetector: add PAN_DELAYED_INTERVAL ( #4666 )
...
When multiswipes are enabled, this fixes the long-standing complaint that swiping to open the menu could unintentionally trigger some light panning. With the introduction of multiswipes, this problem has become more noticeable.
2019-02-28 23:49:23 +01:00
Frans de Jonge
96823df503
[UX] Navigation settings for all devices ( #4680 )
...
Before multiswipes and the gesture manager this was impractical on touch-only devices, but no more!
Also includes some minor textual clarifications on some of the settings.
2019-02-28 22:38:24 +01:00
Frans de Jonge
060902534d
[fix] Gesture manager: more logical position for file browser ( #4679 )
...
See https://github.com/koreader/koreader/pull/4678#issuecomment-468378040
2019-02-28 20:50:43 +01:00
Frans de Jonge
db0467c9f0
[UX] Introduce Taps & Gestures menu ( #4677 )
...
This more logically groups together various settings related to taps and gestures.
Cf. <https://github.com/koreader/koreader/pull/4655#issuecomment-466808273 >.
2019-02-28 20:42:00 +01:00
Frans de Jonge
32d813dc92
[UX] Gesture manager: add action - go to file browser ( #4678 )
...
Fixes #4676 .
2019-02-28 19:07:33 +01:00
Frans de Jonge
a1f7f25eaf
[chore, UX] Migrate Screen menu to MenuSorter & put Screensaver under Screen ( #4675 )
...
Doing more of this is the general purpose of MenuSorter, after all.
This is making some space for a new `Taps and gestures` menu, see <https://github.com/koreader/koreader/pull/4655#issuecomment-466808273 >.
2019-02-28 18:32:11 +01:00
Frans de Jonge
75501d5f83
[fix] ReaderGesture: enable/disable multiswipes without restarting ( #4673 )
2019-02-28 16:27:09 +01:00
Frans de Jonge
abba7ba873
[fix] TimeVal: add dbg:guard against incorrect subtraction order ( #4669 )
...
In principle, any negative subtraction result should be caused by a logical error.
2019-02-27 22:20:47 +01:00
Frans de Jonge
163853afdf
[UX] Gesture manager: add action - show menu ( #4665 )
2019-02-26 18:58:26 +01:00
poire-z
1c0a8c1ef9
cre scroll mode: fix last line of book hidden by footer
...
By scrolling last page a little bit further.
Also fix a few other scroll mode issues, all related
to doc_height not being updated (eg, in the middle of
a book, and doubling the font size, one would not
be able to turn pages and read the 2nd half of the
book...)
2019-02-26 09:43:35 +01:00
poire-z
918f296bd3
cre scroll mode: fix highlights not shown when small pages
...
The idea of looking for highlights 1 page before and after
was not working when you have multiple small pages, and
some scroll mode view was actually showing 3 or 4 pages.
So, rework that by using absolute positions when looking
for highlights present in the scrolled view.
2019-02-26 09:43:35 +01:00
Frans de Jonge
f8f3132315
[UX] Gesture manager: add action - show frontlight dialog ( #4664 )
...
Rationale for the default `down, left` gesture: it's pointing at the location for the frontlight toggle.
2019-02-26 09:27:28 +01:00
Frans de Jonge
6ddba11392
[UX] Alternative update message when ota_version < local_version ( #4661 )
...
See https://github.com/koreader/koreader/issues/4650#issuecomment-466965983 and https://github.com/koreader/koreader/pull/4661#issuecomment-467088984
2019-02-25 22:50:01 +01:00
Frans de Jonge
ff14c7896d
[UX] Gesture manager: add north west = folder up as file manager default ( #4662 )
...
Up, left is also the traditional Opera gesture for parent directory.
2019-02-25 16:07:04 +01:00
Frans de Jonge
47ba296f17
[UX] Gesture manager: more multiswipe defaults ( #4660 )
2019-02-25 14:43:05 +01:00
Frans de Jonge
926150db58
[UX] Gesture manager: add action - go to latest bookmark ( #4657 )
2019-02-24 21:40:27 +01:00
Frans de Jonge
dccebe1fb5
[fix] Gesture manager: send TapForward event for page forward ( #4658 )
...
Otherwise you can get rather unexpected results in paged media and scroll mode.
Workaround suggested by @NiLuJe here: https://github.com/koreader/koreader/pull/4570#discussion_r258693835
2019-02-24 20:41:20 +01:00
Frans de Jonge
7098e6ef35
[fix] Gesture manager: default at the top ( #4656 )
...
Accidentally broken by 1d6948ddf1
2019-02-24 17:36:15 +01:00
Frans de Jonge
1d6948ddf1
[UX] Gesture manager: show selected action in menu ( #4655 )
2019-02-24 17:07:42 +01:00
Frans de Jonge
ab1132e885
[UX] Gesture manager: re-order actions, add Skim option ( #4654 )
...
Also move multiswipes_enabled setting reading into init(),
to avoid it taking effect only after next restart.
2019-02-24 15:12:01 +01:00
Frans de Jonge
91b83c5176
[UX] Gesture manager: delete custom gestures and update menu ( #4652 )
...
Include a safety check to prevent rerecording an existing gesture.
Also extend the default set of gestures to include all of them, and add east south west north for refresh. (I've always thought small diagonal swipe to be rather awkward to trigger.)
See https://github.com/koreader/koreader/pull/4644#issuecomment-466743715 and https://github.com/koreader/koreader/issues/4651 regarding the menu update.
2019-02-24 12:29:49 +01:00
Frans de Jonge
d090f3e651
[fix, UX] GestureDetector: fix multiswipe length detection ( #4649 )
...
Reported by @poire-z, cf. https://github.com/koreader/koreader/pull/4640#issuecomment-466544922
Apparently it's natural for me to make the second swipe slightly longer than the first, so I never noticed a logic issue. I did notice that it seemed slightly harder to make 4-swipe multiswipes than I expected it to be, but those are not necessarily easy gestures to make.
The problem was that I needed to prevent obviously silly gestures like west west west east. In ignoring such duplication, what I accidentally did was to ignore any further movement west after the first multiswipe direction was detected, meaning that the following swipe east could still end up as a relatively western movement overall.
By simply updating the current multiswipe slot in case of the same direction, both problems are prevented. We'll never get the same direction twice, and X moves over to where it's supposed to be on the left.
2019-02-23 21:34:03 +01:00
Martín Fernández
0532d7a507
[Android] (re)enable update downloads using full apks ( #4639 )
2019-02-23 14:25:29 +01:00
Frans de Jonge
92174815a8
[fix] ReaderGesture: don't crash without custom gestures ( #4645 )
...
Silly oversight in https://github.com/koreader/koreader/pull/4644 .
Also remove unused util because apparently CircleCI didn't run on the other PR when it should've.
2019-02-22 21:31:22 +01:00
Frans de Jonge
2e255a1abd
[feat, UX] Add multiswipe recorder ( #4644 )
2019-02-22 20:59:32 +01:00
Frans de Jonge
6246d44068
[fix] Gesture manager: actually register multiswipe ( #4643 )
...
Accidentally broken in https://github.com/koreader/koreader/pull/4623
Also see https://github.com/koreader/koreader/pull/4640#issuecomment-466443328
2019-02-22 16:56:22 +01:00
Frans de Jonge
9a92792551
[feat, UX] Gesture manager: add option - open previous document ( #4641 )
...
Fixes #4333 .
2019-02-22 16:29:19 +01:00
Frans de Jonge
260427d226
[fix] GestureDetector: fix multiswipe direction detection code ( #4640 )
...
Unfortunately a mistake snuck into the final steps of refactoring <https://github.com/koreader/koreader/pull/4607 >.
Thanks to @poire-z for pointing it out [here](https://github.com/koreader/koreader/pull/4607#issuecomment-464856789 ).
2019-02-22 12:36:03 +01:00
Frans de Jonge
ca6c7316e6
[fix] ReaderZooming: work around tiles that are too large ( #4608 )
...
Zooms out until a page can fit in the cache. It's a bit ugly, but better than being stuck. Fixes #3491 .
2019-02-21 11:38:19 +01:00
NiLuJe
afa12ef8ce
[fix] Leave size_t alone in FFI stuff: flip that back to size_t ( #4629 )
2019-02-21 09:56:54 +01:00
NiLuJe
6c29b7da65
[fix] PicDocument: Pass a copy of image_bb in getCoverPageImage() ( #4628 )
...
Avoids a use-after-free in mupdf.scaleBlitBuffer
Fix koreader/koreader-base#821
Thanks for the hint, @poire-z ;).
* As @poire-z suggested, the original unscaled bb should probably be free'd.
2019-02-21 08:59:41 +01:00
Frans de Jonge
8e5c1addf5
[feat] Update check ( #4620 )
...
The concept is quite simple: stick a file on the OTA server named
something like `koreader-appimage-latest-stable` (by analogy with
`koreader-cervantes-latest-stable.zsync`), which contains nothing
but a filename.
The difference with the zsync update is that the link is then launched
in the user's browser (AppImage) or DownloadManager (Android, not yet
implemented).
* Android hasOTAUpdate = no for the moment
2019-02-21 08:26:48 +01:00
NiLuJe
869b8aebd1
[Cervantes, Kobo] Stricter WiFi callback ( #4616 )
...
* Double-checks that the connection was successful, and forcefully kills WiFi if it didn't, to avoid leaving stuff in an inconsistent state.
Should fix #2183
* Limit the turnOffWifi call to devices where it might make some sense to
do
2019-02-20 14:59:33 +01:00
Frans de Jonge
a2c47b35de
[UX] Gesture manager: add paged zoom gestures ( #4610 )
...
References #4333 .
2019-02-20 13:45:14 +01:00
Frans de Jonge
13d4ead330
[fix] Gesture manager: check multiswipe defaults ( #4623 )
...
Pointed out by @poire-z
Also add default previous location action for left, right.
2019-02-20 09:34:44 +01:00
NiLuJe
5495c5d108
[fix] Fix partial refresh when coming out of ScreenSaver in landscape ( #4622 )
...
When we rotate to show a screensaver, restore original rotation *before* closing the ScreenSaver window.
And ensure closing the ScreenSaver *always* triggers a full update, no
matter the settings.
Fix #4621
2019-02-19 18:17:58 +01:00
NiLuJe
e3bcd6c2a9
Really disable HW dithering on Kindle ;) ( #4617 )
...
* Cosmestic tweak to an error message.
PicDocument handles more than just JPEGs ;)
* Bump base
To really disable HW dithering on Kindle ;).
2019-02-19 00:52:28 +01:00
Frans de Jonge
c09045efcd
[fix] GestureDetector: multiswipe rotation ( #4613 )
...
Reported by @poire-z in <https://github.com/koreader/koreader/pull/4607#issuecomment-464622906 >.
Also refactor slightly along the way to make the translations more straightforward.
2019-02-18 16:42:34 +01:00
Martín Fernández
b6683b7a9f
android: update wifi menus
2019-02-18 14:32:35 +01:00
Martín Fernández
4ab7e367b5
strings, not ints
2019-02-18 14:32:35 +01:00
Martín Fernández
04e17424d0
display network settings based on device capabilities + fix android basic network info
2019-02-18 14:32:35 +01:00