Commit Graph

1279 Commits

Author SHA1 Message Date
hius07
f1726a9e5d FileSearcher: consistent results window (#13298) 2025-02-27 18:45:52 +02:00
hius07
7c45700ceb Collections: sort (#13264)
Some checks are pending
macos / macOS 13 x86-64 🔨15.2 🎯10.15 (push) Waiting to run
macos / macOS 14 ARM64 🔨15.4 🎯11.0 (push) Waiting to run
2025-02-22 10:17:19 +02:00
hius07
a641207f79 bookinfomanager: handle zip (#13290)
Some checks are pending
macos / macOS 13 x86-64 🔨15.2 🎯10.15 (push) Waiting to run
macos / macOS 14 ARM64 🔨15.4 🎯11.0 (push) Waiting to run
2025-02-21 08:51:23 +02:00
Frans de Jonge
cee259b885 [plugin] Terminal: improve LDoc module definition for terminputtext.lua (#13273)
Some checks are pending
macos / macOS 13 x86-64 🔨15.2 🎯10.15 (push) Waiting to run
macos / macOS 14 ARM64 🔨15.4 🎯11.0 (push) Waiting to run
Closes #13272.
2025-02-17 15:09:31 +01:00
Frans de Jonge
b8a31ef182 [plugin] NewsDownloader: don't try to strip <script> tags (#13260)
Some checks failed
macos / macOS 13 x86-64 🔨15.2 🎯10.15 (push) Has been cancelled
macos / macOS 14 ARM64 🔨15.4 🎯11.0 (push) Has been cancelled
`<script src="etc"></script>` is turned into `<script/>`, which can cause far too much to be stripped.

While that could be dealt with a bit better, for example by first stripping self-closing and then regular, it feels hacky to do so.

See <https://github.com/koreader/koreader/pull/13188#issuecomment-2660362639>.
2025-02-15 10:37:49 +01:00
David
901b1b5430 [Hotkeys] override self.ui.fonts key_events (#13257)
* Removed [now] unnecessary conditions when removing actions for hotkeys in the `HotKeys:genMenu` function. No longer needed as of #13227

* Added code to reset key events for the overlooked `font` UI component in the `HotKeys:overrideConflictingKeyEvents` function.
2025-02-14 17:23:34 +01:00
Martín Fernández
a1ac782a2f calibre.koplugin: show message when attempting to connect via dispatcher (#13237)
Some checks are pending
macos / macOS 13 x86-64 🔨15.2 🎯10.15 (push) Waiting to run
macos / macOS 14 ARM64 🔨15.4 🎯11.0 (push) Waiting to run
closes #13193

Using an InfoMessage instead of a notification because another infomessage will follow with success/error.
2025-02-12 19:18:37 +01:00
Martín Fernández
eea6c5465d Exporter: migrate to rapidjson (#13204) 2025-02-11 14:28:55 +01:00
hius07
41dd3d5d8a OPDS: raw server filenames for download (#13230)
Some checks are pending
macos / macOS 13 x86-64 🔨15.2 🎯10.15 (push) Waiting to run
macos / macOS 14 ARM64 🔨15.4 🎯11.0 (push) Waiting to run
2025-02-11 14:10:57 +02:00
hius07
68cfd96203 Dispatcher: action list fixes (#13167)
Some checks failed
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Has been cancelled
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Has been cancelled
2025-02-07 19:27:54 +02:00
David
8e886f5631 [Hotkeys] refactor hotkey list and update callbacks (#13219)
Cf.  #13078
2025-02-07 13:19:22 +01:00
Frans de Jonge
56c08020d7 NewsDownloader: process HTML with cre.getBalancedHTML() to ensure self-closing tags like <hr> are closed like <hr/> (#13188)
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
Works around the issue in <https://github.com/koreader/koreader/issues/13173#issuecomment-2628027654>.
2025-02-02 13:34:38 +01:00
Frans de Jonge
763264a102 NewsDownloader: some random cleanup (#13182)
Dead code, redundant comments, indentation.
2025-02-01 18:11:23 +01:00
Frans de Jonge
2604f7da8d NewsDownloader: add support for cache-control and retry-after header
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
2025-01-31 23:06:06 +01:00
Frans de Jonge
7bc8f9bd3d NewsDownloader: update cached content and headers with response 2025-01-31 23:06:06 +01:00
Frans de Jonge
d33247967e NewsDownloader: add If-None-Match to headers
Missing in #13171.
2025-01-31 23:06:06 +01:00
Frans de Jonge
3dba40d884 [chore] NewsDownloader: reduce log verbosity in EpubDownloadBackend 2025-01-31 18:29:10 +01:00
Frans de Jonge
26d19c3c73 [chore] NewsDownloader: remove custom redirect handling
It's been implemented in LuaSocket http.request() in the meantime.
2025-01-31 18:29:10 +01:00
Frans de Jonge
8b31f68462 [chore] NewsDownloader: remove dead code (#13178) 2025-01-31 18:06:39 +01:00
Frans de Jonge
d6941bc339 NewsDownloader: add a cache to reduce wasted bandwidth (#13171)
Closes #13061.
2025-01-31 17:59:08 +01:00
Frans de Jonge
c1f6a02fa0 NewsDownloader: deal with 404 and other error statuses better (#13165)
May be relevant to #9363. In any case one of the most typical kind of failures wasn't treated properly, so a 404 would mess up everything instead of popping up a dialog.
2025-01-29 18:10:13 +01:00
hius07
9bcd09633c Gesture manager and Profiles: improve Dispatcher actions menu (#13078) 2025-01-26 11:10:49 +02:00
hius07
cda2dcaacc BookShortcuts: open file with associated provider (#13106)
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
2025-01-25 12:26:18 +02:00
hius07
42de1fb96e Collections: filter by book status (#13099) 2025-01-25 10:49:35 +02:00
hius07
17504993ae CoverBrowser info_cache: move to core (#13018)
Some checks failed
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Has been cancelled
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Has been cancelled
2025-01-18 10:08:18 +02:00
Frans de Jonge
923b690179 EPUB: limit image download dismiss check display updates to once per second
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
On Wikipedia articles with for example 30 images this reduces the download time from ~12 seconds to ~8 seconds (depending on image size and connection speed), which is fairly significant.
2025-01-18 00:15:27 +01:00
Frans de Jonge
bb93c44346 [minor] Normalize more requires (#13074)
I thought I had them all in <https://github.com/koreader/koreader/pull/13055> but I seem to have missed a few.
2025-01-17 21:20:16 +01:00
beedaddy
84eb04ef17 kosync: Make sure there are no leading or trailing whitespaces (#13077)
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
2025-01-17 07:49:02 +01:00
Frans de Jonge
8314838add [plugin] NewsDownloader: make <title> match less greedy (#13070)
Some checks failed
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Has been cancelled
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Has been cancelled
On most pages it works fine, but on pages with multiple `</title>` it can match very large amounts of text.

Valid examples include `<svg>` in the HTML, where [`<title>`](https://developer.mozilla.org/en-US/docs/Web/SVG/Element/title) is used similar to `title=""` in HTML, but of course there could also simply be invalid pages.
2025-01-15 10:07:27 +01:00
Frans de Jonge
87d1678b02 [minor, plugin] NewsDownloader: fix a string that's concatenated without space or newline (#13071) 2025-01-15 10:06:49 +01:00
Frans de Jonge
eb6d4ff422 EPUB: unify include_images logic (#13063)
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
Other than the slightly different InfoMessage.
2025-01-14 22:23:37 +01:00
Frans de Jonge
4eea3f0cda [i18n, plugins] Wallabag: use ngettext for plural (#13062)
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
2025-01-13 18:26:14 +01:00
Frans de Jonge
12b075a4ac [minor] normalize a few requires (#13055)
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
2025-01-13 08:33:18 +01:00
Frans de Jonge
6792bb0a06 [plugin] Gestures, Hotkeys: attempt to work around corrupted gestures file (#13054)
See #13009 for details.

LuaSettings attempts to read a backup if the main doesn't work. If that doesn't work it returns an empty `data` table. But gestures expects there to be defaults inside.
2025-01-13 08:31:06 +01:00
Frans de Jonge
ea23f0c9aa EPUB: mimetype file should not be compressed (#13057)
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
According to epubcheck.

```
Mimetype file should only contain the string "application/epub+zip" and should not be compressed.
```
2025-01-12 22:09:19 +01:00
hrm
6a0aa958c9 wallabag: Add option to archive locally, instead of deleting + rewording of menu options (#12949)
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
Fix #12712, fix #11687, fix #9151.
2025-01-12 15:28:34 +01:00
Frans de Jonge
9b444cba89 processImg: skip data URI (#13034)
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
This is the underlying reason that The Verge + download full article fails, see <https://github.com/koreader/koreader/issues/12953#issuecomment-2580784621>.
2025-01-09 22:41:36 +01:00
Frans de Jonge
274dd6dab3 [plugin] NewsDownloader: use first feed description if it's a table in RSS (#13032)
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
Similar to the logic for Atom in #12959.

Reported in https://github.com/koreader/koreader/issues/12953#issuecomment-2580784621

Sample feed https://www.engadget.com/rss.xml
2025-01-09 19:10:15 +01:00
Nikola Kotur
ca660f3b55 [exporter] support multiple authors in Nextcloud (#13005)
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
Fixes #12821.
2025-01-06 19:40:35 +01:00
hius07
f0a3e1c63a File list: new display options (#12954)
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
2025-01-05 18:59:28 +02:00
Frans de Jonge
cbe211190f [plugin] ReadTimer: interpret the past as a time tomorrow (#12985)
Fixes #12984.
2025-01-05 17:04:10 +01:00
Frans de Jonge
016592e0a3 [plugin] NewsDownloader: add primitive support for relative URLs (#12980)
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
Fixes #8611.
2025-01-02 12:45:22 +01:00
Frans de Jonge
10f627e3f9 [plugin] NewsDownloader: reduce HTML idiosyncracies (#12976) 2025-01-02 12:42:10 +01:00
Frans de Jonge
c589db9f61 [plugin] NewsDownloader: fail gracefully when date can't be parsed (#12978)
Fixes #9358.
2025-01-01 12:25:31 +01:00
Frans de Jonge
a707b7c163 [plugin, i18n] CoverBrowser: add missing plural (#12968) 2025-01-01 10:56:04 +01:00
Frans de Jonge
871b8cf381 [plugin] NewsDownloader: download images without extension (#12969)
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
Fixes #12967.
2024-12-31 15:49:25 +01:00
Frans de Jonge
a94a2e07ce [lang] Exporter → Nextcloud: use proper arrow (#12970) 2024-12-31 11:44:26 +01:00
Frans de Jonge
b93ce8ba4b [plugin] NewsDownloader: switch default to download_full_article=false (#12965)
Some checks are pending
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (10.15, 13, x86-64, 15.2) (push) Waiting to run
macos / macOS ${{ matrix.image }} ${{ matrix.platform }} 🔨${{ matrix.xcode_version }} 🎯${{ matrix.deployment_target }} (11.0, 14, ARM64, 15.4) (push) Waiting to run
It's a saner default. Much of the time it won't just work but it'll work *significantly better* than `download_full_article=true`.

Additionally it should reduce the chance of being seen as abuse, cf. <https://github.com/koreader/koreader/issues/12953#issuecomment-2565973079>.

Also see #3172.

Since both the UI and the default config include the value, impact may be surprisingly limited.
2024-12-31 00:18:11 +01:00
Frans de Jonge
8de936e4d8 [plugin] NewsDownloader: fix Atom download_full_article=false not working (#12959)
Fixes #3172.
2024-12-31 00:15:36 +01:00
Frans de Jonge
b8af072d9f [plugin] NewsDownloader: support single-entry feeds (#12958)
Fixes #12953.
2024-12-29 17:50:39 +01:00