Commit Graph

2231 Commits

Author SHA1 Message Date
hius07 ea46d71634 Highlights: anchored dialogs (#12810) 2024-12-05 18:53:59 +02:00
hius07 58adb685d1 Collections: search (#12776) 2024-12-04 14:09:26 +02:00
Brendan LeFebvre 798a64998f webdav: show folders with same name as current folder (#12788)
Closes #12783
2024-11-24 08:59:12 +01:00
hius07 47feaaa1df Highlights: page boxes cache (#12768) 2024-11-23 14:05:05 +02:00
hius07 93f2fa6702 Highlight: line height (#12721) 2024-11-21 07:54:23 +02:00
hius07 24d8baf3ec Notebook file (#12699) 2024-11-21 07:53:22 +02:00
jonnyl2 fa20344a15 ReaderHighlight: Highlight menu, change 'Delete' to Trash can icon (#12758)
Closes #12754; as discussed there.
2024-11-20 20:31:20 +01:00
Frans de Jonge 11981821f6 [minor] ReaderHighlight: normalize more spelling of PDF (#12732) 2024-11-12 21:06:31 +01:00
Frans de Jonge d3893b6cf1 [minor] ReaderHighlight: normalize spelling of PDF (#12731) 2024-11-12 21:05:16 +01:00
hius07 c2d1099976 Profiles: more auto-exec triggers 2 (#12691) 2024-10-31 20:26:21 +02:00
hius07 97a7ebefb9 Text editor: rotate (#12658) 2024-10-29 20:49:43 +02:00
mergen3107 f8446538c0 Fix KOReader spelling in the code (#12670) 2024-10-24 10:46:46 +02:00
hius07 54e33d27ea ReaderHighlight: fix color for extended highlight in pdf (#12654)
Closes #12653.
2024-10-18 20:59:31 +02:00
jonnyl2 a4dcfd2d52 ReaderFont: fix "new" fonts in generated font test document (#12646)
New fonts were not rendering in their own font because
the font names were modified directly in the face_list table.
2024-10-18 16:46:57 +02:00
hius07 1493a092db Cloud storage: fix sorting non-English filenames (#12644)
Reported in #12638.
2024-10-15 09:30:57 +02:00
hius07 f143f5f8b1 ReaderHighlight: adjustable "Edit highlight" dialog position (#12599) 2024-10-11 19:26:33 +03:00
hius07 76deedfb73 Menu widget: rotation handler (#12573) 2024-10-10 10:54:59 +03:00
hius07 92bcbe06f6 readertypeset: fix margins info (#12609) 2024-10-07 22:17:14 +03:00
Benoit Pierre 120d418b7e android: switch to monolibtic mode (#12576)
We can get rid of the `libs` and `sdcv` symlink in application files.

Depend on koreader/koreader-base#1920.

Close #12348.
2024-10-02 09:19:57 +02:00
hius07 b937a079ea Profiles: auto-execute on events (#12564) 2024-09-30 19:22:20 +03:00
hius07 4cdef40f97 File search: improve (#12549) 2024-09-28 19:47:56 +03:00
David 08205c47c8 [ReaderFooter] Update status bar in real time when inverting page turning (#12424) 2024-09-25 21:16:06 +02:00
NiLuJe e887be693f optionsutil: Simplify the public formatFlexSize wrapper
Pull the dimension_units from in there,
instead of asking callers to do that.
2024-09-16 17:12:43 +02:00
NiLuJe 3cbd75b385 ReaderTypeset: Use formatFlexSize in onSetPageMargins
Instead of enforcing px.

Also decouple the footer from the bottom margin report to make things
clearer given this change.
2024-09-16 17:12:43 +02:00
NiLuJe f8890a310d optionsutil: Rename real_size_string to formatFlexSize, and make it public
Use it in the ReaderView:onPageGapUpdate notification, instead of
enforcing "px" there.
2024-09-16 17:12:43 +02:00
NiLuJe af51bfafad ReaderView: Fix onPageGapUpdate
The input value should go through Screen:scaleBySize(), as in onReadSettings

Otherwise, choosing an option from ConfigDialog leads to different
results than on document open, as one is scaled, but not the other.

Issue extant since the inception of page gap configuration,
way back in #5705

(The intended and correct behavior if of course to scale this, e.g., the
setting is a "koreader flex pixel", not an absolute actual px value ;).
2024-09-16 17:12:43 +02:00
NiLuJe da74691515 Chore: Don't cache static data tables (ui/elements, ui/data, kb layouts & co) (#12519)
Using `require` didn't make much sense since most of them are only used in a single place anyway, and it takes care of a few weird interactions in the process (besides not polluting `package.loaded` with useless crap ;)).
2024-09-16 17:11:42 +02:00
NiLuJe aa6cadb1ee SyncService: Only require online connectivity when using Dropbox (#12520)
Aligns with the CloudStorage behavior.

Fix #12518
2024-09-16 17:10:45 +02:00
hius07 bf290e0c2b Write highlights into PDF: revisited (#12509) 2024-09-14 15:21:26 +03:00
weijiuqiao 04aa0cbde3 CloudSync: handles potentially incompatible backup and incoming dbs (#12470)
This pr removes the backup db (sync db) of the cloud syncing strategy when a different server location is used. This is to avoid the situation when later incoming db is not based on previously uploaded sync db.
2024-09-14 14:08:03 +02:00
hius07 d3beecd3f5 ReaderAnnotation: skip old highlights with invalid xpointers (#12494) 2024-09-14 11:17:26 +03:00
NiLuJe 57ceaf3f07 SetDefaultsWidget: Don't crash on unknown custom keys
Just warn about it in the logs.
This will only show up when opening the advanced settings UI, so we'll
keep it for now instead of *also* deleting the offending kv pair,
for the sake of not randomly destroying user content...
2024-09-11 13:20:39 +02:00
cccslater 94c57b9f42 [NT] Call GotoViewRel for page up/down on useDPadAsActionKeys devices (#12495)
Page buttons call `GotoViewRel` again (not `GotoPosRel`). Fixes https://github.com/koreader/koreader/issues/12380
2024-09-09 21:17:48 +02:00
hius07 5476301034 ButtonDialogTitle: remove (#12394) 2024-09-07 20:11:35 +03:00
hius07 7572a812cc Highlights popup dialog: add "Color" and "Details" buttons (#12461) 2024-09-07 17:56:40 +03:00
NiLuJe ffc4929504 ReaderHighlight: Fix an old typo in the OCR help string (#12479)
Noticed while triaging #12478 ;)
2024-09-07 16:23:56 +02:00
NiLuJe f8df76e5c4 misc: Move cleanupSelectedText to util (#12477)
Instead of duplicating it across ReaderHighlight, languagesupport, and potentially VocabBuilder.

Re: #12469
2024-09-06 23:06:28 +02:00
NiLuJe 8f5215abfd ReaderView: Fix a couple of edge-cases in onReaderFooterVisibilityChange (#12466)
Namely, it trips a `recalculate` that snaps `visible_area` to `page_area` edges (depending on zoom/reading direction), while we do *NOT* actually want to move the view, just increase/decrease its height ;).

(This *might* happen more reliably than it used to since https://github.com/koreader/koreader/pull/11425 & https://github.com/koreader/koreader/pull/11557)

Also deal with scroll mode while I'm here, as recalculate doesn't affect scroll mode at all, since that uses an *array* of on-screen pages, each with their own visible_area, page_area & state.

Fix #12454
2024-09-06 15:28:35 +02:00
NiLuJe cf83dc8bd3 ReaderView: Don't crash on pre-#11044 highlights without a color field (#12438)
(They'll be drawn in gray, as before)

Regression since #11044
(https://github.com/koreader/koreader/pull/11044#issuecomment-2322820971)
2024-08-31 22:55:59 +02:00
hius07 49e885321a Exporter: choose highlight styles to be exported (#12431) 2024-08-31 19:28:48 +03:00
hius07 38c8d66b5b readerhighlight: fix showing anchored popup dialog 2024-08-31 15:18:18 +02:00
hius07 6f7277d269 readersearch: fix building findall result 2024-08-31 15:18:18 +02:00
hius07 963aa9ac7c filemanagerhistory: fix update list after deleting a file 2024-08-31 15:18:18 +02:00
hius07 ee5a4169d1 webdavapi: fix 'resourcetype' property check 2024-08-31 15:18:18 +02:00
Rowan Decker 60e0e3ef45 Add color highlight menu (#11044) 2024-08-30 22:10:43 +02:00
NiLuJe a486acf48b FileManagerSetDefaults: Handle strings that we default to nil (#12433)
The actual defaults table is a hash, so we have no way of salvaging it from there without using a custom NULL type or another kind of sentinel value.
But since everything that actually *uses* the offending defaults expects a nil, don't rock the boat, and just fix the Advanced Settings widget to be able to deal with it.

Fix #11679
Regression since #9546
2024-08-30 16:02:24 +02:00
NiLuJe 7e52c15de2 FileManager: Handle the FlushSettings event (#12425)
It's used on Android when we're murdered by the task switcher, and when doing an OTA update.

Fix #12124
2024-08-29 11:28:16 +02:00
NiLuJe 5fc5386e87 ReadTimer: Don't blindly repaint the footer in update_status_bars
Send a dedicated event that will let ReaderFooter check if we actually have anything relevant to display, and will do the usual "should I repaint/refresh" checks ;).

Fix #12323
Regression since #12002
2024-08-28 23:53:38 +02:00
NiLuJe a86271b8f1 ReaderFooter: Use maybeUpdateFooter in onBookMetadataChanged
I'm not sure that one could ever have been truly problematic, but let's
be cautious ;).
2024-08-28 23:53:38 +02:00
jonnyl2 f3005906d4 Readerfont: current font on top in menu; new fonts from current session on top in font test doc (#12410)
* Move down call setupFaceMenuTable(); list current font on top in menu if sorted by recently selected.

* New fonts from current session listed on top in fonts test documents; small wording changes
2024-08-26 22:51:29 +02:00