Deluan Quintão
47e3fdb1b8
fix(server): do not try to validate credentials if the request is canceled ( #3650 )
...
Pipeline: Test, Lint, Build / Get version info (push) Has been cancelled
Pipeline: Test, Lint, Build / Lint Go code (push) Has been cancelled
Pipeline: Test, Lint, Build / Test Go code (push) Has been cancelled
Pipeline: Test, Lint, Build / Test JS code (push) Has been cancelled
Pipeline: Test, Lint, Build / Lint i18n files (push) Has been cancelled
Pipeline: Test, Lint, Build / Check Docker configuration (push) Has been cancelled
Pipeline: Test, Lint, Build / Build (darwin/amd64) (push) Has been cancelled
Pipeline: Test, Lint, Build / Build (darwin/arm64) (push) Has been cancelled
Pipeline: Test, Lint, Build / Build (linux/386) (push) Has been cancelled
Pipeline: Test, Lint, Build / Build (linux/amd64) (push) Has been cancelled
Pipeline: Test, Lint, Build / Build (linux/arm/v5) (push) Has been cancelled
Pipeline: Test, Lint, Build / Build (linux/arm/v6) (push) Has been cancelled
Pipeline: Test, Lint, Build / Build (linux/arm/v7) (push) Has been cancelled
Pipeline: Test, Lint, Build / Build (linux/arm64) (push) Has been cancelled
Pipeline: Test, Lint, Build / Build (windows/386) (push) Has been cancelled
Pipeline: Test, Lint, Build / Build (windows/amd64) (push) Has been cancelled
Pipeline: Test, Lint, Build / Push Docker manifest (push) Has been cancelled
Pipeline: Test, Lint, Build / Build Windows installers (push) Has been cancelled
Pipeline: Test, Lint, Build / Package/Release (push) Has been cancelled
Pipeline: Test, Lint, Build / Upload Linux PKG (push) Has been cancelled
Signed-off-by: Deluan <deluan@navidrome.org >
2025-01-16 20:32:11 -05:00
Deluan
beff1afad7
fix(subsonic): make Share's lastVisited optional
...
Signed-off-by: Deluan <deluan@navidrome.org >
2025-01-09 16:10:53 -05:00
Deluan
627417dae3
fix(server): add disc number to fake path.
...
Also revert "feat(server): enable "Report Real Path" by default"
Signed-off-by: Deluan <deluan@navidrome.org >
2024-12-02 09:35:39 -05:00
Deluan Quintão
a557f37834
refactor: small improvements and clean up ( #3423 )
...
* refactor: replace custom map functions with slice.Map
* refactor: extract StringerValue function
* refactor: removed unnecessary if
* chore: removed invalid comment
* refactor: replace more map functions
* chore: fix FFmpeg typo
2024-10-22 22:54:31 -04:00
Kendall Garner
0a650de357
feat(subsonic): add MusicBrainz ID and Sort Name to getArtists
2024-10-22 22:00:31 -04:00
Deluan
23bebe4e06
feat(subsonic): getOpenSubsonicExtensions is now public
2024-10-21 17:21:18 -04:00
Deluan Quintão
8b5af67647
feat(subsonic): support OS clearing play queue ( #3399 )
2024-10-16 10:59:22 -04:00
Deluan Quintão
a9334b7787
feat(ui): show user's lastAccess ( #3342 )
...
* feat(server): update user's lastAccess
* feat(ui): show user's lastAccess
2024-09-30 20:46:10 -04:00
Deluan
fc5d18feb7
Change error code type to avoid integer overflow conversion warning
2024-09-01 14:49:48 -04:00
Deluan
5d81849603
Fix lint errors
2024-08-21 12:15:25 -04:00
Deluan
232c45bd06
Increase artist image url sizes.
...
See https://support.symfonium.app/t/artist-picture-less-compressed/4447
2024-06-10 16:33:41 -04:00
Deluan
3252fab171
Increase artist image url sizes.
...
See https://support.symfonium.app/t/artist-picture-less-compressed/4447
2024-06-08 13:32:57 -04:00
Deluan
b4ef1b1e38
Replace gg.If with cmp.Or
2024-06-05 22:48:00 -04:00
Caio Cotts
0488fb92cb
Fix image stuttering ( #3035 )
...
* Fix image stuttering.
* Fix docker publishing for PRs
* Write tests for new square parameter.
* Simplify code for createImage.
---------
Co-authored-by: Deluan Quintão <deluan@navidrome.org >
2024-05-24 20:19:26 -04:00
Drew Weymouth
b6fce0e686
Fix XML marshaling of OpenSubsonic structured lyrics ( #3041 )
2024-05-22 12:15:14 -04:00
Guilherme Souza
98218d045e
Deterministic pagination in random albums sort ( #1841 )
...
* Deterministic pagination in random albums sort
* Reseed on first random page
* Add unit tests
* Use rand in Subsonic API
* Use different seeds per user on SEEDEDRAND() SQLite3 function
* Small refactor
* Fix id mismatch
* Add seeded random to media_file (subsonic endpoint `getRandomSongs`)
* Refactor
* Remove unneeded import
---------
Co-authored-by: Deluan <deluan@navidrome.org >
2024-05-18 14:10:53 -04:00
Deluan
0a763b91d5
Fix lint error
2024-05-17 21:46:59 -04:00
Deluan
478c709a64
Associate main entities with library
2024-05-12 21:37:42 -04:00
Deluan
477bcaee58
Store MusicFolder as a library in DB
2024-05-12 21:37:42 -04:00
Deluan
081ef85db6
Rename MediaFolder to Library
2024-05-12 21:37:42 -04:00
Deluan
30ae468dc1
Uses Unix milliseconds support from standard Go lib
2024-05-11 19:50:30 -04:00
Deluan
3a2a5e961b
Add samplingRate to OpenSubsonic responses
2024-05-11 17:57:45 -04:00
Deluan
ed83c22632
Do not panic if when updatePlaylist is called with a non-existent ID.
...
Fix #2876
2024-05-11 15:37:50 -04:00
Deluan
bb96d455f8
Replace sync.WaitGroup with more appropriate errgroup.Group
2024-05-10 15:27:07 -04:00
Deluan
677d9947f3
Make dependency injection more consistent
2024-05-08 22:21:38 -04:00
Deluan
dd4374cec6
Limit access to Jukebox for admins only (configurable).
...
Closes #2849
2024-05-07 19:35:43 -04:00
Deluan
2c06a4234e
Fix int types in OpenSubsonic responses.
...
Refer to https://support.symfonium.app/t/symfonium-sync-crashes-when-tpos-is-not-an-int/4204
2024-05-01 13:57:11 -04:00
crazygolem
1e96b858a9
Add support for Reverse Proxy auth in Subsonic endpoints ( #2558 )
...
* feat(subsonic): Add support for Reverse Proxy auth - #2557
Signed-off-by: Jeremiah Menétrey <superjun1@gmail.com >
* Small refactoring
---------
Signed-off-by: Jeremiah Menétrey <superjun1@gmail.com >
Co-authored-by: Deluan Quintão <deluan@navidrome.org >
2024-04-27 13:47:42 -04:00
Deluan
f7fc17c0f7
Add OpenSubsonic channelCount
2024-04-26 17:51:04 -04:00
crazygolem
18143fa5a1
Use the RealIP middleware also behind a reverse proxy ( #2858 )
...
* Use the RealIP middleware only behind a reverse proxy
* Fix proxy ip source in tests
* Fix test for PR#2087
The PR did not update the test after changing the behavior, but the test still
passed because another condition was preventing the user from being created in
the test.
* Use RealIP even without a trusted reverse proxy
* Use own type for context key
* Fix casing to follow go's conventions
* Do not apply RealIP middleware twice
* Fix IP source in logs
The most interesting data point in the log message is the proxy's IP, but
having the client IP too can help identify integration issues.
2024-04-25 20:43:58 -04:00
Deluan
4865d04ec6
Fix DiscTitle OpenSubsonic compatibility. Closes #2929
2024-04-08 19:05:36 -04:00
Kendall Garner
f12dfb485a
Expose OpenSubsonic release date for album ( #2906 )
...
* [enhancement]: OS expose release date for album, make original optional
* not optional
* remove omitempty
2024-04-03 07:30:01 -04:00
Deluan
176329343a
Send Subsonic formatted response on marshalling errors
2024-02-17 10:39:29 -05:00
Deluan
166eb37787
Use Go builtin min/max func
2024-02-16 21:53:16 -05:00
Deluan
d8e1748928
Return 500 in case of Subsonic response marshalling errors
2024-02-16 19:59:24 -05:00
Deluan
0b2cf30096
Don't swallow marshalling errors in the Subsonic API
2024-02-16 18:43:36 -05:00
Caio Cotts
bf2bcb1279
Fix null values in DB ( #2840 )
...
* Fix album image_files being null.
* Fix small nitpick.
* Use ExecContext instead of Exec.
* Change more columns to not null and set default values.
* Remove columns that don't need to be changed from migration.
* Fix typo.
* Remove unnecessary select statements.
* Remove duplicate code.
* Do not apply changes to radio table.
* Do not apply changes full_text columns and respective indexes.
* Fix musicbrainz columns.
* Rename migration.
* Make ExternalInfoUpdatedAt nullable
* Make Share's timestamps nullable
---------
Co-authored-by: Deluan Quintão <deluan@navidrome.org >
2024-02-07 20:45:08 -05:00
Deluan
5125558f52
Make Subsonic search query default to "" if not present.
...
See https://github.com/orgs/music-assistant/discussions/414#discussioncomment-8265985
2024-01-27 20:00:02 -05:00
Deluan
e50382e3bf
Fix ReplayGain values not being retrieved from DB
2023-12-27 21:14:54 -05:00
Kendall Garner
814161d78d
Add OS Lyrics extension ( #2656 )
...
* draft commit
* time to fight pipeline
* round 2 changes
* remove unnecessary line
* fight taglib. again
* make taglib work again???
* add id3 tags
* taglib 1.12 vs 1.13
* use int instead for windows
* store as json now
* add migration, more tests
* support repeated line, multiline
* fix ms and support .m, .mm, .mmm
* address some concerns, make cpp a bit safer
* separate responses from model
* remove [:]
* Add trace log
* Try to unblock pipeline
* Fix merge errors
* Fix SIGSEGV error (proper handling of empty frames)
* Add fallback artist/title to structured lyrics
* Rename conflicting named vars
* Fix tests
* Do we still need ffmpeg in the pipeline?
* Revert "Do we still need ffmpeg in the pipeline?"
Yes we do.
This reverts commit 87df7f6df7 .
* Does this passes now, with a newer ffmpeg version?
* Revert "Does this passes now, with a newer ffmpeg version?"
No, it does not :(
This reverts commit 372eb4b0ae .
* My OCD made me do it :P
---------
Co-authored-by: Deluan Quintão <deluan@navidrome.org >
2023-12-27 20:20:29 -05:00
Deluan
51e07d4cb5
Add log.IsGreaterOrEqualTo, that take into consideration path-scoped log levels
2023-12-25 16:35:16 -05:00
Deluan Quintão
15e1394fa3
Implement originalReleaseDate in OpenSubsonic responses. ( #2733 )
...
See https://github.com/opensubsonic/open-subsonic-api/pull/80
2023-12-22 21:03:55 -05:00
Deluan
dfcc189cff
Replace all utils.Param* with req.Params
2023-12-21 17:41:09 -05:00
Deluan
00597e01e9
Add req.Params to replace utils.Param*
2023-12-21 16:32:37 -05:00
Deluan
12aae5e951
Some cleanup in the jukebox code, specially log messages
2023-12-17 13:15:47 -05:00
Deluan
932152eb7e
Change required fields in Subsonic Jukebox endpoint
...
See discussion here: https://gitlab.com/ultrasonic/ultrasonic/-/issues/1266#note_1621953651
2023-12-17 13:15:47 -05:00
Deluan
546aa26a0a
Removed duplicated code
2023-12-09 14:11:07 -05:00
Deluan
aed0309161
Return AlbumID3 in search3 results
2023-12-09 14:01:22 -05:00
Deluan
465cc091b0
Convert internal disc number representation to int
2023-12-09 13:53:38 -05:00
Deluan
2c9035fdd0
Add discTitles to OpenSubsonic responses
2023-12-09 13:53:38 -05:00