From e5438c1e5698dfd32ba2ff9ac7e2656efc8620bd Mon Sep 17 00:00:00 2001 From: zsviczian Date: Mon, 16 Jun 2025 11:52:12 +0000 Subject: [PATCH] fixed determineFocusDistance function signature preventing ExcaliBrain from rendering --- manifest-beta.json | 2 +- manifest.json | 2 +- src/shared/Dialogs/Messages.ts | 4 ++++ src/shared/ExcalidrawAutomate.ts | 3 +++ src/types/excalidrawLib.d.ts | 3 ++- 5 files changed, 11 insertions(+), 3 deletions(-) diff --git a/manifest-beta.json b/manifest-beta.json index dd5626c..667e3f2 100644 --- a/manifest-beta.json +++ b/manifest-beta.json @@ -1,7 +1,7 @@ { "id": "obsidian-excalidraw-plugin", "name": "Excalidraw", - "version": "2.12.3", + "version": "2.12.4", "minAppVersion": "1.1.6", "description": "An Obsidian plugin to edit and view Excalidraw drawings", "author": "Zsolt Viczian", diff --git a/manifest.json b/manifest.json index a06f6ac..52ac609 100644 --- a/manifest.json +++ b/manifest.json @@ -1,7 +1,7 @@ { "id": "obsidian-excalidraw-plugin", "name": "Excalidraw", - "version": "2.12.3", + "version": "2.12.4", "minAppVersion": "1.1.6", "description": "An Obsidian plugin to edit and view Excalidraw drawings", "author": "Zsolt Viczian", diff --git a/src/shared/Dialogs/Messages.ts b/src/shared/Dialogs/Messages.ts index b8af288..413ced9 100644 --- a/src/shared/Dialogs/Messages.ts +++ b/src/shared/Dialogs/Messages.ts @@ -17,6 +17,10 @@ I build this plugin in my free time, as a labor of love. Curious about the philo
Buy Me a Coffee at ko-fi.com
`, +"2.12.4":` +## Fixed +- ExaliBrain did not render after the 2.12.3 update. [#2384](https://github.com/zsviczian/obsidian-excalidraw-plugin/issues/2384) +`, "2.12.3":` ## Minor fixes - Includes all recent updates and fixes from excalidraw.com diff --git a/src/shared/ExcalidrawAutomate.ts b/src/shared/ExcalidrawAutomate.ts index b71a36f..5550347 100644 --- a/src/shared/ExcalidrawAutomate.ts +++ b/src/shared/ExcalidrawAutomate.ts @@ -1715,6 +1715,7 @@ export class ExcalidrawAutomate { id = id ?? nanoid(); const startPoint = points[0] as GlobalPoint; const endPoint = points[points.length - 1] as GlobalPoint; + const elementsMap = arrayToMap(this.getElements()); this.elementsDict[id] = { points: normalizeLinePoints(points), lastCommittedPoint: null, @@ -1723,6 +1724,7 @@ export class ExcalidrawAutomate { focus: formatting?.startObjectId ? determineFocusDistance( this.getElement(formatting?.startObjectId) as ExcalidrawBindableElement, + elementsMap, endPoint, startPoint, ) @@ -1734,6 +1736,7 @@ export class ExcalidrawAutomate { focus: formatting?.endObjectId ? determineFocusDistance( this.getElement(formatting?.endObjectId) as ExcalidrawBindableElement, + elementsMap, startPoint, endPoint, ) diff --git a/src/types/excalidrawLib.d.ts b/src/types/excalidrawLib.d.ts index fc52c82..b79d45b 100644 --- a/src/types/excalidrawLib.d.ts +++ b/src/types/excalidrawLib.d.ts @@ -52,7 +52,7 @@ type EmbeddedLink = declare namespace ExcalidrawLib { type ElementUpdate = Omit< Partial, - "id" | "version" | "versionNonce" + "id" | "updated" >; type ExportOpts = { @@ -108,6 +108,7 @@ declare namespace ExcalidrawLib { function determineFocusDistance( element: ExcalidrawBindableElement, + elementsMap: ElementsMap, a: GlobalPoint, b: GlobalPoint, ): number;