Rename FeedlyEntryIdentifierProviding.entryIds to FeedlyEntryIdentifierProviding.entryIDs.

This commit is contained in:
Brent Simmons
2023-09-12 21:24:12 -07:00
parent 0588426ac4
commit 09bfd76af9
6 changed files with 16 additions and 16 deletions

View File

@@ -9,21 +9,21 @@
import Foundation
protocol FeedlyEntryIdentifierProviding: AnyObject {
var entryIds: Set<String> { get }
var entryIDs: Set<String> { get }
}
final class FeedlyEntryIdentifierProvider: FeedlyEntryIdentifierProviding {
private (set) var entryIds: Set<String>
private (set) var entryIDs: Set<String>
init(entryIds: Set<String> = Set()) {
self.entryIds = entryIds
init(entryIDs: Set<String> = Set()) {
self.entryIDs = entryIDs
}
func addEntryIds(from provider: FeedlyEntryIdentifierProviding) {
entryIds.formUnion(provider.entryIds)
func addEntryIDs(from provider: FeedlyEntryIdentifierProviding) {
entryIDs.formUnion(provider.entryIDs)
}
func addEntryIds(in articleIds: [String]) {
entryIds.formUnion(articleIds)
func addEntryIDs(in articleIDs: [String]) {
entryIDs.formUnion(articleIDs)
}
}

View File

@@ -32,15 +32,15 @@ class FeedlyDownloadArticlesOperation: FeedlyOperation, Logging {
}
override func run() {
var articleIds = missingArticleEntryIdProvider.entryIds
articleIds.formUnion(updatedArticleEntryIdProvider.entryIds)
var articleIds = missingArticleEntryIdProvider.entryIDs
articleIds.formUnion(updatedArticleEntryIdProvider.entryIDs)
self.logger.debug("Requesting \(articleIds.count, privacy: .public) articles.")
let feedlyAPILimitBatchSize = 1000
for articleIds in Array(articleIds).chunked(into: feedlyAPILimitBatchSize) {
let provider = FeedlyEntryIdentifierProvider(entryIds: Set(articleIds))
let provider = FeedlyEntryIdentifierProvider(entryIDs: Set(articleIds))
let getEntries = FeedlyGetEntriesOperation(account: account, service: getEntriesService, provider: provider)
getEntries.delegate = self
self.operationQueue.add(getEntries)

View File

@@ -13,7 +13,7 @@ final class FeedlyFetchIdsForMissingArticlesOperation: FeedlyOperation, FeedlyEn
private let account: Account
private(set) var entryIds = Set<String>()
private(set) var entryIDs = Set<String>()
init(account: Account) {
self.account = account
@@ -23,7 +23,7 @@ final class FeedlyFetchIdsForMissingArticlesOperation: FeedlyOperation, FeedlyEn
account.fetchArticleIDsForStatusesWithoutArticlesNewerThanCutoffDate { result in
switch result {
case .success(let articleIds):
self.entryIds.formUnion(articleIds)
self.entryIDs.formUnion(articleIds)
self.didFinish()
case .failure(let error):

View File

@@ -53,7 +53,7 @@ final class FeedlyGetEntriesOperation: FeedlyOperation, FeedlyEntryProviding, Fe
}
override func run() {
service.getEntries(for: provider.entryIds) { result in
service.getEntries(for: provider.entryIDs) { result in
switch result {
case .success(let entries):
self.entries = entries

View File

@@ -16,7 +16,7 @@ protocol FeedlyGetStreamIdsOperationDelegate: AnyObject {
/// Single responsibility is to get the stream ids from Feedly.
final class FeedlyGetStreamIdsOperation: FeedlyOperation, FeedlyEntryIdentifierProviding, Logging {
var entryIds: Set<String> {
var entryIDs: Set<String> {
guard let ids = streamIds?.ids else {
assertionFailure("Has this operation been addeded as a dependency on the caller?")
return []

View File

@@ -33,7 +33,7 @@ class FeedlyGetUpdatedArticleIdsOperation: FeedlyOperation, FeedlyEntryIdentifie
self.init(account: account, resource: all, service: service, newerThan: newerThan)
}
var entryIds: Set<String> {
var entryIDs: Set<String> {
return storedUpdatedArticleIds
}