Merge pull request #4014 from stuartbreckenridge/fix/4006

Internationalises `notificationDisplayName`
This commit is contained in:
Brent Simmons
2023-06-04 10:52:10 -07:00
committed by GitHub
7 changed files with 42 additions and 6 deletions

View File

@@ -254,15 +254,15 @@ public final class WebFeed: Feed, Renamable, Hashable, ObservableObject {
public var notificationDisplayName: String {
#if os(macOS)
if self.url.contains("www.reddit.com") {
return NSLocalizedString("Show notifications for new posts", comment: "notifyNameDisplay / Reddit")
return NSLocalizedString("label.text.show-notifications-for-new-posts", comment: "Show notifications for new posts")
} else {
return NSLocalizedString("Show notifications for new articles", comment: "notifyNameDisplay / Default")
return NSLocalizedString("label.text.show-notifications-for-new-articles", comment: "Show notifications for new articles")
}
#else
if self.url.contains("www.reddit.com") {
return NSLocalizedString("Notify about new posts", comment: "notifyNameDisplay / Reddit")
return NSLocalizedString("label.text.show-notifications-for-new-posts", comment: "Notify about new posts")
} else {
return NSLocalizedString("Notify about new articles", comment: "notifyNameDisplay / Default")
return NSLocalizedString("label.text.show-notifications-for-new-articles", comment: "Notify about new articles")
}
#endif
}

View File

@@ -208,7 +208,7 @@
"button.title.advanced" = "Advanced";
/* Always Use Reader View */
"button.title.always-use-reader-view" = "Always User Reader View";
"button.title.always-use-reader-view" = "Always Use Reader View";
/* Article Theme */
"button.title.article-theme" = "Article Theme";
@@ -574,6 +574,12 @@
/* An extension that enables a share menu item that passes article data to a third-party application. */
"label.text.share-extension-explainer" = "An extension that enables a share menu item that passes article data to a third-party application.";
/* Show notifications for new articles */
"label.text.show-notifications-for-new-articles" = "Show notifications for new articles";
/* Show notifications for new posts */
"label.text.show-notifications-for-new-posts" = "Show notifications for new posts";
/* Sign in to your BazQux account. */
"label.text.sign-in-bazqux" = "Sign in to your BazQux account.";

View File

@@ -204,7 +204,7 @@
"button.title.advanced" = "Advanced";
/* Always Use Reader View */
"button.title.always-use-reader-view" = "Always User Reader View";
"button.title.always-use-reader-view" = "Always Use Reader View";
/* Article Theme */
"button.title.article-theme" = "Article Theme";
@@ -567,6 +567,12 @@
/* An extension that enables a share menu item that passes article data to a third-party application. */
"label.text.share-extension-explainer" = "An extension that enables a share menu item that passes article data to a third-party application.";
/* Show notifications for new articles */
"label.text.show-notifications-for-new-articles" = "Show notifications for new articles";
/* Show notifications for new posts */
"label.text.show-notifications-for-new-posts" = "Show notifications for new posts";
/* Sign in to your BazQux account. */
"label.text.sign-in-bazqux" = "Sign in to your BazQux account.";

View File

@@ -573,6 +573,12 @@
/* An extension that enables a share menu item that passes article data to a third-party application. */
"label.text.share-extension-explainer" = "一个通过共享菜单将文章数据传输给第三方应用的扩展。";
/* Show notifications for new articles */
"label.text.show-notifications-for-new-articles" = "有新文章时推送通知";
/* Show notifications for new posts */
"label.text.show-notifications-for-new-posts" = "有新帖子时推送通知";
/* Sign in to your BazQux account. */
"label.text.sign-in-bazqux" = "登录到你的 BazQux 账户。";

View File

@@ -754,6 +754,12 @@
/* Self-hosted accounts sync your feeds across all your devices */
"label.text.self-hosted-accounts-explainer" = "Self-hosted accounts sync your feeds across all your devices";
/* Show notifications for new articles */
"label.text.show-notifications-for-new-articles" = "Notify about new articles";
/* Show notifications for new posts */
"label.text.show-notifications-for-new-posts" = "Notify about new posts";
/* Small */
"label.text.small" = "Small";

View File

@@ -739,6 +739,12 @@
/* Self-hosted accounts sync your feeds across all your devices */
"label.text.self-hosted-accounts-explainer" = "Self-hosted accounts sync your feeds across all your devices";
/* Show notifications for new articles */
"label.text.show-notifications-for-new-articles" = "Notify about new articles";
/* Show notifications for new posts */
"label.text.show-notifications-for-new-posts" = "Notify about new posts";
/* Small */
"label.text.small" = "Small";

View File

@@ -748,6 +748,12 @@
/* Self-hosted accounts sync your feeds across all your devices */
"label.text.self-hosted-accounts-explainer" = "自托管帐户可以在所有设备上同步你的订阅。";
/* Notify about new articles */
"label.text.show-notifications-for-new-articles" = "新文章通知";
/* Notify about new posts */
"label.text.show-notifications-for-new-posts" = "新帖子通知";
/* Small */
"label.text.small" = "小";