Stop storing conditional GET info — rely on URLSession built-in caching to handle conditional GET.

This commit is contained in:
Brent Simmons
2024-11-27 20:36:39 -08:00
parent 0e8eac3c56
commit 680c4a4ff4
8 changed files with 0 additions and 48 deletions

View File

@@ -919,12 +919,6 @@ public final class Account: DisplayNameProvider, UnreadCountProvider, Container,
// MARK: - Debug
public func debugDropConditionalGetInfo() {
#if DEBUG
flattenedWebFeeds().forEach{ $0.dropConditionalGetInfo() }
#endif
}
public func debugRunSearch() {
#if DEBUG
let t1 = Date()

View File

@@ -782,7 +782,6 @@ private extension CloudKitAccountDelegate {
return
}
self.articlesZone.deleteArticles(webFeedExternalID) { result in
feed.dropConditionalGetInfo()
self.refreshProgress.completeTask()
completion(result)
}

View File

@@ -85,7 +85,6 @@ class CloudKitAcountZoneDelegate: CloudKitZoneDelegate {
func removeWebFeed(_ externalID: String) {
if let webFeed = account?.existingWebFeed(withExternalID: externalID), let containers = account?.existingContainers(withWebFeed: webFeed) {
containers.forEach {
webFeed.dropConditionalGetInfo()
$0.removeWebFeed(webFeed)
}
}

View File

@@ -26,7 +26,6 @@ public extension WebFeed {
public static let editedName = "editedName"
public static let authors = "authors"
public static let contentHash = "contentHash"
public static let conditionalGetInfo = "conditionalGetInfo"
}
}

View File

@@ -123,15 +123,6 @@ public final class WebFeed: Feed, Renamable, Hashable {
}
}
public var conditionalGetInfo: HTTPConditionalGetInfo? {
get {
return metadata.conditionalGetInfo
}
set {
metadata.conditionalGetInfo = newValue
}
}
public var contentHash: String? {
get {
return metadata.contentHash
@@ -253,14 +244,6 @@ public final class WebFeed: Feed, Renamable, Hashable {
self.metadata = metadata
}
// MARK: - API
public func dropConditionalGetInfo() {
conditionalGetInfo = nil
contentHash = nil
sinceToken = nil
}
// MARK: - Hashable
public func hash(into hasher: inout Hasher) {

View File

@@ -26,7 +26,6 @@ final class WebFeedMetadata: Codable {
case contentHash
case isNotifyAboutNewArticles
case isArticleExtractorAlwaysOn
case conditionalGetInfo
case sinceToken
case externalID = "subscriptionID"
case folderRelationship
@@ -104,14 +103,6 @@ final class WebFeedMetadata: Codable {
}
}
var conditionalGetInfo: HTTPConditionalGetInfo? {
didSet {
if conditionalGetInfo != oldValue {
valueDidChange(.conditionalGetInfo)
}
}
}
var sinceToken: String? {
didSet {
if externalID != oldValue {

View File

@@ -704,12 +704,6 @@ extension AppDelegate {
AccountManager.shared.defaultAccount.debugRunSearch()
}
@IBAction func debugDropConditionalGetInfo(_ sender: Any?) {
#if DEBUG
AccountManager.shared.activeAccounts.forEach{ $0.debugDropConditionalGetInfo() }
#endif
}
@IBAction func debugTestCrashReporterWindow(_ sender: Any?) {
#if DEBUG
crashReportWindowController = CrashReportWindowController(crashLogText: "This is a test crash log.")

View File

@@ -509,13 +509,6 @@
<modifierMask key="keyEquivalentModifierMask"/>
<menu key="submenu" title="Debug" id="NOT-8E-ykF">
<items>
<menuItem title="Drop Conditional Get Info" id="btO-Tb-2qS">
<modifierMask key="keyEquivalentModifierMask"/>
<connections>
<action selector="debugDropConditionalGetInfo:" target="Voe-Tx-rLC" id="X24-9X-rwG"/>
</connections>
</menuItem>
<menuItem isSeparatorItem="YES" id="Dij-Nu-eot"/>
<menuItem title="Test Crash Reporter Window" id="gVd-kQ-efj">
<modifierMask key="keyEquivalentModifierMask"/>
<connections>