renun/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire synced 2025-08-12 06:26:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add documentation comment and rename window parameter

Browse Source
This commit is contained in:
Nate Weaver
2022-10-08 01:27:35 -05:00
parent 7f59f94542
commit 7f69ddc749
4 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Mac/Browser.swift
View File

@@ -76,7 +76,13 @@ extension Browser {
extension Browser {
static func open(_ urlStrings: [String], alertingInWindow window: NSWindow?, invertPreference: Bool = false) {
/// Open multiple pages in the default browser, warning if over a certain number of URLs are passed.
/// - Parameters:
/// - urlStrings: The URL strings to open.
/// - window: The window on which to display the "over limit" alert sheet. If `nil`, will be displayed as a
/// modal dialog.
/// - invertPreference: Whether to invert the user's "Open web pages in background in browser" preference.
static func open(_ urlStrings: [String], fromWindow window: NSWindow?, invertPreference: Bool = false) {
if urlStrings.count > 500 {
return
}

2
Mac/MainWindow/MainWindowController.swift
View File

@@ -343,7 +343,7 @@ class MainWindowController : NSWindowController, NSUserInterfaceValidations {
@IBAction func openArticleInBrowser(_ sender: Any?) {
guard let selectedArticles else { return }
let urlStrings = selectedArticles.compactMap { $0.preferredLink }
Browser.open(urlStrings, alertingInWindow: window, invertPreference: NSApp.currentEvent?.modifierFlags.contains(.shift) ?? false)
Browser.open(urlStrings, fromWindow: window, invertPreference: NSApp.currentEvent?.modifierFlags.contains(.shift) ?? false)
}
@IBAction func openInBrowser(_ sender: Any?) {

2
Mac/MainWindow/Timeline/TimelineViewController+ContextualMenus.swift
View File

@@ -93,7 +93,7 @@ extension TimelineViewController {
return
}
Browser.open(urlStrings, alertingInWindow: self.view.window)
Browser.open(urlStrings, fromWindow: self.view.window)
}
@objc func copyURLFromContextualMenu(_ sender: Any?) {

2
Mac/MainWindow/Timeline/TimelineViewController.swift
View File

@@ -316,7 +316,7 @@ final class TimelineViewController: NSViewController, UndoableCommandRunner, Unr
@objc func openArticleInBrowser(_ sender: Any?) {
let urlStrings = selectedArticles.compactMap { $0.preferredLink }
Browser.open(urlStrings, alertingInWindow: self.view.window)
Browser.open(urlStrings, fromWindow: self.view.window)
}
@IBAction func toggleStatusOfSelectedArticles(_ sender: Any?) {