renun/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire synced 2025-08-12 06:26:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

🩹 Fixes incorrect refresh control visibility

Browse Source 
Makes `TimelineViewController` a `UISplitViewControllerDelegate`.

When the display mode is such that the feeds, timeline and article are visible, the timeline refresh control is hidden.
When the display mode is such that the timeline and article are visible, the timeline refresh control is visible.
This commit is contained in:
Stuart Breckenridge
2025-01-18 15:11:08 +08:00
committed by Brent Simmons
parent 5a2816334f
commit 8eee73cf26
1 changed files with 38 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
iOS/MainTimeline/MainTimelineViewController.swift
View File

@@ -59,7 +59,10 @@ class MainTimelineViewController: UITableViewController, UndoableCommandRunner {
NotificationCenter.default.addObserver(self, selector: #selector(contentSizeCategoryDidChange), name: UIContentSizeCategory.didChangeNotification, object: nil)
NotificationCenter.default.addObserver(self, selector: #selector(displayNameDidChange), name: .DisplayNameDidChange, object: nil)
NotificationCenter.default.addObserver(self, selector: #selector(willEnterForeground(_:)), name: UIApplication.willEnterForegroundNotification, object: nil)
// Split View Controller Delegate
splitViewController?.delegate = self
// Initialize Programmatic Buttons
filterButton = UIBarButtonItem(image: AppAssets.filterInactiveImage, style: .plain, target: self, action: #selector(toggleFilter(_:)))
firstUnreadButton = UIBarButtonItem(image: AppAssets.nextUnreadArticleImage, style: .plain, target: self, action: #selector(firstUnread(_:)))
@@ -600,11 +603,44 @@ extension MainTimelineViewController: UISearchBarDelegate {
}
}
extension TimelineViewController: UISplitViewControllerDelegate {
func splitViewController(_ svc: UISplitViewController, willChangeTo displayMode: UISplitViewController.DisplayMode) {
switch displayMode {
case .automatic:
return
case .secondaryOnly:
return
case .oneBesideSecondary:
// Timeline + Article - show the refresh control on the timeline
self.toolbarItems?[2].customView?.alpha = 1.0
case .oneOverSecondary:
return
case .twoBesideSecondary:
return
case .twoOverSecondary:
return
case .twoDisplaceSecondary:
// Sidebar + Timeline + Article - hide the refresh control on the timeline
self.toolbarItems?[2].customView?.alpha = 0.0
case .primaryHidden:
return
case .allVisible:
return
case .primaryOverlay:
return
@unknown default:
return
}
}
}
// MARK: Private
private extension MainTimelineViewController {
func configureToolbar() {
func configureToolbar() {
guard !(splitViewController?.isCollapsed ?? true) else {
return
}