renun/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire synced 2025-08-12 06:26:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Change Feed Provider interface to make it work better with refreshing WebFeeds.

Browse Source
This commit is contained in:
Maurice Parker
2020-04-16 11:25:39 -05:00
parent eb02568409
commit b3afee0252
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Frameworks/Account/FeedProvider/FeedProvider.swift
View File

@@ -19,15 +19,15 @@ public enum FeedProviderAbility {
public protocol FeedProvider {
/// Informs the caller of the ability for this feed provider to service the given URL
func ability(_ url: URLComponents, forUsername: String?) -> FeedProviderAbility
func ability(_ urlComponents: URLComponents, forUsername: String?) -> FeedProviderAbility
/// Provide the iconURL of the given URL
func iconURL(_ url: URLComponents, completion: @escaping (Result<String, Error>) -> Void)
func iconURL(_ urlComponents: URLComponents, completion: @escaping (Result<String, Error>) -> Void)
/// Construct a ParsedFeed that can be used to create and store a new Feed
func provide(_ url: URLComponents, completion: @escaping (Result<ParsedFeed, Error>) -> Void)
func provide(_ urlComponents: URLComponents, completion: @escaping (Result<ParsedFeed, Error>) -> Void)
/// Refresh all the article entries (ParsedItems)
func refresh(_ url: URLComponents, completion: @escaping (Result<Set<ParsedItem>, Error>) -> Void)
func refresh(_ webFeed: WebFeed, completion: @escaping (Result<Set<ParsedItem>, Error>) -> Void)
}

8
Frameworks/Account/FeedProvider/Twitter/TwitterFeedProvider.swift
View File

@@ -84,16 +84,16 @@ public struct TwitterFeedProvider: FeedProvider {
return .available
}
public func iconURL(_ url: URLComponents, completion: @escaping (Result<String, Error>) -> Void) {
let screenName = extractScreenName(url)
public func iconURL(_ urlComponents: URLComponents, completion: @escaping (Result<String, Error>) -> Void) {
let screenName = extractScreenName(urlComponents)
fetchIconURL(screenName: screenName, completion: completion)
}
public func provide(_ url: URLComponents, completion: @escaping (Result<ParsedFeed, Error>) -> Void) {
public func provide(_ urlComponents: URLComponents, completion: @escaping (Result<ParsedFeed, Error>) -> Void) {
// TODO: Finish implementation
}
public func refresh(_ url: URLComponents, completion: @escaping (Result<Set<ParsedItem>, Error>) -> Void) {
public func refresh(_ webFeed: WebFeed, completion: @escaping (Result<Set<ParsedItem>, Error>) -> Void) {
// TODO: Finish implementation
}