Commit Graph

633 Commits

Author SHA1 Message Date
Nate Weaver
35e59dd6dd Change parameter label 2022-11-12 17:10:55 -06:00
Nate Weaver
016a2948c4 Run alert modally if no window is passed; add doc comments 2022-11-12 17:10:55 -06:00
Nate Weaver
cdf2dd5d64 Alert the user the first time they try to copy URLs from articles where some have no URLs 2022-11-12 17:10:55 -06:00
Nate Weaver
6dc1393143 Always respect the user's "Open in Browser" preference 2022-11-12 17:10:55 -06:00
Nate Weaver
7f69ddc749 Add documentation comment and rename window parameter 2022-11-12 17:10:55 -06:00
Nate Weaver
7f59f94542 Move multi-url opening to an extension on Browser
Also reword the alert a bit and add the number of pages to the "Open" button
2022-11-12 17:10:55 -06:00
Nate Weaver
49e8b921ba Add a currentLinks property 2022-11-12 17:10:55 -06:00
Nate Weaver
48c5afffcd copyExternalURL should copy externalLinks 2022-11-12 17:10:55 -06:00
Nate Weaver
fd75387d9c Don't do anything if there are more than 500 URLs 2022-11-12 17:10:55 -06:00
Nate Weaver
2fbc2fb628 Support opening multiple articles in browser from main menu
Move openArticleURLs() to MainWindowController.
2022-11-12 17:10:55 -06:00
Nate Weaver
3420346fa3 Support opening multiple articles in the browser 2022-11-12 17:10:55 -06:00
Nate Weaver
a129fae73c Copy multiple article URLs from the Edit menu as well 2022-11-12 17:10:55 -06:00
Nate Weaver
93afee7e3c Use plural title for multiple URLs 2022-11-12 17:10:55 -06:00
Nate Weaver
1cd21892c1 Support copying multiple article URLs
Requires and RSCore update.
2022-11-12 17:10:55 -06:00
Maurice Parker
0e0d194ec9 Fix toolbar items that change their images based on current state 2022-11-12 11:21:44 -06:00
Maurice Parker
d9a24e039c Merge pull request #3741 from stuartbreckenridge/3739
Fixes theme menu picker
2022-11-12 10:44:00 -06:00
Stuart Breckenridge
2f1f673afe Fixes #3739 - Theme menu updates after selection 2022-11-12 14:46:42 +08:00
Ethan Wong
220b2287a0 Improve shareToolbarItem's behavior in text-only mode. 2022-11-12 12:03:49 +08:00
Ethan Wong
d3ad6c5a0f Adding menuFormRepresentation to toolbars to properly handle text-only mode. 2022-11-12 10:37:09 +08:00
Ethan Wong
c0936e3272 Prefer default button implementation for standard toolbar items. 2022-11-12 10:36:13 +08:00
Maurice Parker
eba6c364da Change how we display progress per #3566. 2022-11-11 17:16:42 -06:00
Stuart Breckenridge
871d751640 var to let 2022-10-06 20:52:11 +08:00
Stuart Breckenridge
1711cb4c90 Removes the need for AboutView and Notifications
- Subclassed NSHostingController manages the tab bar to keep things tidy.
2022-10-06 20:42:34 +08:00
Stuart Breckenridge
2896e0328d consistent naming 2022-10-03 21:25:50 +08:00
Stuart Breckenridge
b3b2025387 moves notification name 2022-10-03 21:18:42 +08:00
Stuart Breckenridge
05aca1c995 About Views
- Tidied up iOS
- Adds refreshed About view to macOS 12+
- About.plist is now shared
2022-10-03 21:16:51 +08:00
Mario Guzman
1eb4002c78 Fix timeline, details views for proper toolbar scroll behavior
Both the details and timeline container views were not extending behind the toolbar and thus content would not show when scrolled behind it. Top anchors should anchor to the top of the super view rather than safe area guides and AppKit automatically adjusts the scroll insets for NSToolbar and optionally (if available) NSTitlebarAccessoryViewController. This allows for the divider to appear when content scrolls behind it and for content to "shine through" the translucency of the NSToolbar.
2022-10-01 12:03:51 -07:00
Maurice Parker
573806c0ca Added Share to the File menu. Fixes #3692 2022-09-27 16:23:20 -05:00
Maurice Parker
d100c64d80 Add right-click action to the Article Extractor Button. Fixes #3695 2022-09-27 12:02:45 -05:00
Maurice Parker
9566947dee Add optional toolbar items for Mark Above as Read and Mark Below as Read. Fixes #3686 2022-09-24 14:41:55 -05:00
Stuart Breckenridge
0dd4689bf0 Logging changes
- Adds `Logging` protocol
- Moves to Swift-style `OSLog` usage

os_log to Logger

os_log audit

Replacment of os.log with Logging
2022-09-04 21:31:03 +08:00
Maurice Parker
bff3c26490 Added missing protocol conformance 2022-07-26 17:40:19 -05:00
Daniel Jalkut
99797586b1 Add support for in-article find when the detail view is showing a regular article or extracted article content. 2022-07-18 13:04:10 -04:00
haikusw
3b9465f21e Add #unavailable check so bug fix only executes in macOS 11. Add @available to flag when we can remove this bug-fix code altogether. 2022-06-20 23:12:56 -07:00
haikusw
4c7f1362b5 Fix for #3543
Noticed that the window size wasn't returning the new value and that's why using the window size to calculate the size to restore it to we were incrementing the original size by one.
Not sure if this breaks the fix that this bigSurOffsetFix was implementing though because I can't replicate that on macOS 12.4
2022-06-15 23:56:02 -07:00
Maurice Parker
b80d7dc24e Merge pull request #3587 from haikusw/fix3580v2
Address #3580 by avoiding use of per-window properties.
2022-06-08 13:48:00 -07:00
haikusw
eae1eec246 rename to shorter version since we no longer need to distinguish between this and other dragOperation type. 2022-06-08 13:14:49 -07:00
Maurice Parker
6386a51f43 Merge pull request #3532 from Wevah/article-copy-order-fix
Return [Article] from articlesForIndexes() instead of Set<Article>
2022-06-08 12:44:45 -07:00
Tyler
665e97232d Address 3580 by using only the items in the DraggingInfo to handle the drag and no view properties associated with a single window.
Remove cached `draggedNodes` optimization and just always use the data on the dragging pasteboard because it works both within the same window and across two windows.

Add support for WebFeedPasteboardWriter to include a parent containerName in the pasteboard dictionary written for a WebFeed object (which doesn't know about it's parent) because we need this for drag and drop to be able to perform a move operation.

Fix issue with dragged feeds not knowing their parent folder and delete deleting the wrong item by telling WebFeedPasteboardWriter what the container of items is.  Remove code that is now unused now that draggedNodes is removed and consolidate code that was expanded to handle both node and pasteboard items since we are just using pasteboard items now.
2022-06-04 20:24:48 -07:00
Nate Weaver
ae09d52940 Return [Article] from articlesForIndexes() instead of Set<Article> 2022-04-17 15:26:37 -05:00
Ethan Wong
5e2fe5f610 Add proper OSLog argument for os_log calls. 2022-04-04 13:51:53 +08:00
Sean Santry
f802165959 Save Sidebar open/collapsed state between launches. Fixes #2707 2022-01-30 22:31:43 -05:00
Maurice Parker
ae33228fe3 Merge branch 'main' into ios-6.2 2022-01-22 11:14:30 -08:00
Maurice Parker
2eb82af473 Merge pull request #3413 from J-rg/fix-3268
Fix blurry sidebar symbols (#3268)
2022-01-22 09:32:38 -08:00
Stuart Breckenridge
b08d9dfe73 if #available mac
Removes if #available for anything less than macOS 11
2022-01-22 20:55:09 +08:00
J-rg
b11db14017 Fix blurry sidebar symbols (#3268) 2022-01-22 03:53:50 +01:00
Stuart Breckenridge
d680fe0988 WKWebpagePreferences added to macOS 2022-01-22 08:39:57 +08:00
Ethan Wong
06278879bc Fix: bottom inset of TimelineTableView disappeared on macOS Monterey 2022-01-10 08:16:42 +08:00
Dimitris Apostolou
94ae4d348c Fix typos 2022-01-05 00:25:20 +02:00
Maurice Parker
09652bff81 Remove Mark Read on Scroll code 2021-12-29 14:44:40 -08:00