build(deps): bump third-party/build-deps from 94369e6 to 3d8430f

Bumps [third-party/build-deps](https://github.com/LizardByte/build-deps) from `94369e6` to `3d8430f`.
- [Commits](94369e6377...3d8430ffb1)

---
updated-dependencies:
- dependency-name: third-party/build-deps
  dependency-version: 3d8430ffb1ab13c5aba49dcc64dbf253c61092ac
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

.gitattributes

@@ -1,6 +1,5 @@
-# ensure dockerfiles are checked out with LF line endings
+# ensure Linux specific files are checked out with LF line endings
 Dockerfile text eol=lf
 *.dockerfile text eol=lf
-
-# ensure flatpak lint json files are checked out with LF line endings
 *flatpak-lint-*.json text eol=lf
+*.sh text eol=lf

.github/matchers/copr-ci.json

@@ -0,0 +1,17 @@
+{
+  "problemMatcher": [
+    {
+      "owner": "copr-ci-gcc",
+      "pattern": [
+        {
+          "regexp": "^/?(?:[^/]+/){5}([^:]+):(\\d+):(\\d+):\\s+(?:fatal\\s+)?(warning|error):\\s+(.*)$",
+          "file": 1,
+          "line": 2,
+          "column": 3,
+          "severity": 4,
+          "message": 5
+        }
+      ]
+    }
+  ]
+}

.github/matchers/docker.json

@@ -0,0 +1,17 @@
+{
+  "problemMatcher": [
+    {
+      "owner": "docker-gcc",
+      "pattern": [
+        {
+          "regexp": "^(?:#\\d+\\s+\\d+\\.\\d+\\s+)?/?(?:[^/]+/){2}([^:]+):(\\d+):(\\d+):\\s+(?:fatal\\s+)?(warning|error):\\s+(.*)$",
+          "file": 1,
+          "line": 2,
+          "column": 3,
+          "severity": 4,
+          "message": 5
+        }
+      ]
+    }
+  ]
+}

.github/matchers/gcc-strip3.json

@@ -0,0 +1,17 @@
+{
+  "problemMatcher": [
+    {
+      "owner": "gcc-strip3",
+      "pattern": [
+        {
+          "regexp": "^/?(?:[^/]+/){3}([^:]+):(\\d+):(\\d+):\\s+(?:fatal\\s+)?(warning|error):\\s+(.*)$",
+          "file": 1,
+          "line": 2,
+          "column": 3,
+          "severity": 4,
+          "message": 5
+        }
+      ]
+    }
+  ]
+}

.github/matchers/gcc.json

@@ -0,0 +1,29 @@
+{
+  "problemMatcher": [
+    {
+      "owner": "gcc",
+      "pattern": [
+        {
+          "regexp": "^(.*):(\\d+):(\\d+):\\s+(?:fatal\\s+)?(warning|error):\\s+(.*)$",
+          "file": 1,
+          "line": 2,
+          "column": 3,
+          "severity": 4,
+          "message": 5
+        }
+      ]
+    },
+    {
+      "owner": "doxygen",
+      "pattern": [
+        {
+          "regexp": "^.*?([A-Za-z]:[\\\\/][^:]+|[\\\\/][^:]+):(\\d+): ([a-zA-Z]+): (.+)$",
+          "file": 1,
+          "line": 2,
+          "severity": 3,
+          "message": 4
+        }
+      ]
+    }
+  ]
+}

.github/workflows/_release-notifier.yml

@@ -20,4 +20,6 @@ jobs:
     uses: LizardByte/.github/.github/workflows/__call-release-notifier.yml@master
     if: github.repository_owner == 'LizardByte'
     secrets:
+      GH_EMAIL: ${{ secrets.GH_BOT_EMAIL }}
+      GH_NAME: ${{ secrets.GH_BOT_NAME }}
       GH_TOKEN: ${{ secrets.GH_BOT_TOKEN }}

.github/workflows/_update-flathub-repo.yml

@@ -26,4 +26,6 @@ jobs:
     uses: LizardByte/.github/.github/workflows/__call-update-flathub-repo.yml@master
     if: github.repository_owner == 'LizardByte'
     secrets:
+      GH_EMAIL: ${{ secrets.GH_BOT_EMAIL }}
+      GH_NAME: ${{ secrets.GH_BOT_NAME }}
       GH_TOKEN: ${{ secrets.GH_BOT_TOKEN }}

.github/workflows/_update-pacman-repo.yml

@@ -26,4 +26,6 @@ jobs:
     uses: LizardByte/.github/.github/workflows/__call-update-pacman-repo.yml@master
     if: github.repository_owner == 'LizardByte'
     secrets:
+      GH_EMAIL: ${{ secrets.GH_BOT_EMAIL }}
+      GH_NAME: ${{ secrets.GH_BOT_NAME }}
       GH_TOKEN: ${{ secrets.GH_BOT_TOKEN }}

.github/workflows/ci-copr.yml

@@ -16,6 +16,10 @@ on:
         required: false
       COPR_CLI_CONFIG:
         required: false
+      GH_BOT_TOKEN:
+        required: false
+      VIRUSTOTAL_API_KEY:
+        required: false
 
 concurrency:
   group: "_${{ github.workflow }}-${{ github.ref }}"
@@ -45,7 +49,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Download build artifacts
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v5
         with:
           path: artifacts
           pattern: build-*

.github/workflows/ci-flatpak.yml

@@ -73,15 +73,16 @@ jobs:
             cmake \
             flatpak
 
-          sudo su $(whoami) -c "flatpak --user remote-add --if-not-exists flathub \
-            https://flathub.org/repo/flathub.flatpakrepo"
+          sudo su "$(whoami)" -c "flatpak --user remote-add --if-not-exists flathub \
+            https://flathub.org/repo/flathub.flatpakrepo
+          "
 
-          sudo su $(whoami) -c "flatpak --user install -y flathub \
+          sudo su "$(whoami)" -c "flatpak --user install -y flathub \
             org.flatpak.Builder \
             org.freedesktop.Platform/${{ matrix.arch }}/${PLATFORM_VERSION} \
             org.freedesktop.Sdk/${{ matrix.arch }}/${PLATFORM_VERSION} \
             org.freedesktop.Sdk.Extension.node${NODE_VERSION}/${{ matrix.arch }}/${PLATFORM_VERSION} \
-            "
+          "
 
           flatpak run org.flatpak.Builder --version
 
@@ -101,9 +102,11 @@ jobs:
             flatpak-${{ matrix.arch }}-
 
       - name: Configure Flatpak Manifest
+        env:
+          BRANCH: ${{ github.head_ref }}
         run: |
           # variables for manifest
-          branch="${{ github.head_ref }}"
+          branch="${{ env.BRANCH }}"
           build_version=${{ inputs.release_version }}
           commit=${{ inputs.release_commit }}
 
@@ -137,19 +140,20 @@ jobs:
 
       - name: Debug Manifest
         working-directory: build
-        run: cat ${APP_ID}.yml
+        run: cat "${APP_ID}.yml"
 
       - name: Build Linux Flatpak
         working-directory: build
         run: |
-          sudo su $(whoami) -c "flatpak run org.flatpak.Builder \
+          echo "::add-matcher::.github/matchers/gcc-strip3.json"
+          sudo su "$(whoami)" -c "flatpak run org.flatpak.Builder \
             --arch=${{ matrix.arch }} \
             --force-clean \
             --repo=repo \
             --sandbox \
             --stop-at=cuda build-sunshine ${APP_ID}.yml"
           cp -r .flatpak-builder copy-of-flatpak-builder
-          sudo su $(whoami) -c "flatpak run org.flatpak.Builder \
+          sudo su "$(whoami)" -c "flatpak run org.flatpak.Builder \
             --arch=${{ matrix.arch }} \
             --force-clean \
             --repo=repo \
@@ -157,15 +161,16 @@ jobs:
             build-sunshine ${APP_ID}.yml"
           rm -rf .flatpak-builder
           mv copy-of-flatpak-builder .flatpak-builder
-          sudo su $(whoami) -c "flatpak build-bundle \
+          sudo su "$(whoami)" -c "flatpak build-bundle \
             --arch=${{ matrix.arch }} \
             ./repo \
             ../artifacts/sunshine_${{ matrix.arch }}.flatpak ${APP_ID}"
-          sudo su $(whoami) -c "flatpak build-bundle \
+          sudo su "$(whoami)" -c "flatpak build-bundle \
             --runtime \
             --arch=${{ matrix.arch }} \
             ./repo \
             ../artifacts/sunshine_debug_${{ matrix.arch }}.flatpak ${APP_ID}.Debug"
+          echo "::remove-matcher owner=gcc-strip3::"
 
       - name: Lint Flatpak
         working-directory: build
@@ -177,7 +182,7 @@ jobs:
             --exceptions \
             --user-exceptions "${exceptions_file}" \
             manifest \
-            ${APP_ID}.yml
+            "${APP_ID}.yml"
 
           echo "Linting flatpak repo"
           # TODO: add arg
@@ -193,13 +198,13 @@ jobs:
         if: matrix.arch == 'x86_64'
         run: |
           mkdir -p flathub/modules
-          cp ./build/generated-sources.json ./flathub/
-          cp ./build/package-lock.json ./flathub/
-          cp ./build/${APP_ID}.yml ./flathub/
-          cp ./build/${APP_ID}.metainfo.xml ./flathub/
-          cp ./packaging/linux/flatpak/README.md ./flathub/
-          cp ./packaging/linux/flatpak/flathub.json ./flathub/
-          cp -r ./packaging/linux/flatpak/modules/. ./flathub/modules/
+          cp "./build/generated-sources.json" "./flathub/"
+          cp "./build/package-lock.json" "./flathub/"
+          cp "./build/${APP_ID}.yml" "./flathub/"
+          cp "./build/${APP_ID}.metainfo.xml" "./flathub/"
+          cp "./packaging/linux/flatpak/README.md" "./flathub/"
+          cp "./packaging/linux/flatpak/flathub.json" "./flathub/"
+          cp -r "./packaging/linux/flatpak/modules/." "./flathub/modules/"
           # submodules will need to be handled in the workflow that creates the PR
 
           # create the archive

.github/workflows/ci-homebrew.yml

@@ -73,9 +73,13 @@ jobs:
           brew install python3
 
       - name: Configure formula
+        env:
+          HEAD_REF: ${{ github.head_ref }}
+          PR_HEAD_REF: ${{ github.event.pull_request.head.ref }}
+          PR_DEFAULT_BRANCH: ${{ github.event.pull_request.head.repo.default_branch }}
         run: |
           # variables for formula
-          branch="${{ github.head_ref }}"
+          branch="${{ env.HEAD_REF }}"
           build_version=${{ inputs.release_version }}
           commit=${{ inputs.release_commit }}
 
@@ -96,9 +100,9 @@ jobs:
           else
             echo "This is a PR event"
             clone_url=${{ github.event.pull_request.head.repo.clone_url }}
-            branch="${{ github.event.pull_request.head.ref }}"
-            default_branch="${{ github.event.pull_request.head.repo.default_branch }}"
-            tag="${{ github.event.pull_request.head.ref }}"
+            branch="${{ env.PR_HEAD_REF }}"
+            default_branch="${{ env.PR_DEFAULT_BRANCH }}"
+            tag="${{ env.PR_HEAD_REF }}"
           fi
           echo "Branch: ${branch}"
           echo "Clone URL: ${clone_url}"
@@ -143,8 +147,9 @@ jobs:
           export DISPLAY=:1
           Xvfb ${DISPLAY} -screen 0 1024x768x24 &
 
-          echo "DISPLAY=${DISPLAY}" >> $GITHUB_ENV
+          echo "DISPLAY=${DISPLAY}" >> "${GITHUB_ENV}"
 
+      - run: echo "::add-matcher::.github/matchers/gcc-strip3.json"
       - name: Validate Homebrew Formula
         id: test
         if: matrix.release != true
@@ -156,6 +161,7 @@ jobs:
           publish: false
           token: ${{ secrets.GH_TOKEN }}
           validate: true
+      - run: echo "::remove-matcher owner=gcc-strip3::"
 
       - name: Setup python
         id: python

.github/workflows/ci-linux.yml

@@ -79,8 +79,8 @@ jobs:
             --enable-x11 \
             --enable-glx \
             --enable-wayland \
-            --without-legacy  # emgd, nvctrl, fglrx
-          make -j $(nproc)
+            --without-legacy
+          make -j "$(nproc)"
           sudo make install
           cd .. && rm -rf libva-*
 
@@ -91,6 +91,7 @@ jobs:
           COMMIT: ${{ inputs.release_commit }}
         run: |
           chmod +x ./scripts/linux_build.sh
+          echo "::add-matcher::.github/matchers/gcc.json"
           ./scripts/linux_build.sh \
             --publisher-name='${{ github.repository_owner }}' \
             --publisher-website='https://app.lizardbyte.dev' \
@@ -98,12 +99,13 @@ jobs:
             --skip-cleanup \
             --skip-package \
             --ubuntu-test-repo ${{ matrix.EXTRA_ARGS }}
+          echo "::remove-matcher owner=gcc::"
 
       - name: Set AppImage Version
         if: matrix.name == 'AppImage'
         run: |
           version=${{ inputs.release_version }}
-          echo "VERSION=${version}" >> $GITHUB_ENV
+          echo "VERSION=${version}" >> "${GITHUB_ENV}"
 
       - name: Package Linux - AppImage
         if: matrix.name == 'AppImage'

.github/workflows/ci-windows.yml

@@ -199,12 +199,12 @@ jobs:
           ignore_list=$(IFS=,; echo "${ignore_packages[*]}")
 
           # install pinned dependencies
-          if [ -n "$tarballs" ]; then
-            pacman -U --noconfirm ${tarballs}
+          if [ -n "${tarballs}" ]; then
+            pacman -U --noconfirm "${tarballs}"
           fi
 
           # Only add --ignore if we have packages to ignore
-          if [ -n "$ignore_list" ]; then
+          if [ -n "${ignore_list}" ]; then
             pacman -Syu --noconfirm --ignore="${ignore_list}" "${dependencies[@]}"
           else
             pacman -Syu --noconfirm "${dependencies[@]}"
@@ -251,7 +251,7 @@ jobs:
 
           # step output
           echo "python-path=${python_path}"
-          echo "python-path=${python_path}" >> $GITHUB_OUTPUT
+          echo "python-path=${python_path}" >> "${GITHUB_OUTPUT}"
 
       - name: Build Windows
         shell: msys2 {0}
@@ -272,7 +272,9 @@ jobs:
             -DSUNSHINE_PUBLISHER_NAME='${{ github.repository_owner }}' \
             -DSUNSHINE_PUBLISHER_WEBSITE='https://app.lizardbyte.dev' \
             -DSUNSHINE_PUBLISHER_ISSUE_URL='https://app.lizardbyte.dev/support'
+          echo "::add-matcher::.github/matchers/gcc.json"
           ninja -C build
+          echo "::remove-matcher owner=gcc::"
 
       - name: Package Windows
         shell: msys2 {0}

.github/workflows/ci.yml

@@ -151,7 +151,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Download coverage artifact
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v5
         with:
           name: coverage-${{ matrix.name }}
           path: _coverage
@@ -192,7 +192,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Download build artifacts
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v5
         with:
           path: artifacts
           pattern: build-*
@@ -225,7 +225,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Download homebrew artifacts
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v5
         with:
           name: beta-Homebrew
           path: homebrew

.github/workflows/localize.yml

@@ -48,9 +48,9 @@ jobs:
           if [ -f "${{ env.file }}" ];
           then
               rm ${{ env.file }}
-              echo "new_file=false" >> $GITHUB_ENV
+              echo "new_file=false" >> "${GITHUB_ENV}"
           else
-              echo "new_file=true" >> $GITHUB_ENV
+              echo "new_file=true" >> "${GITHUB_ENV}"
           fi
 
           # extract the new strings
@@ -67,7 +67,7 @@ jobs:
 
           # set the variable with minimal output, replacing `\t` with ` `
           OUTPUT=$(git diff --numstat locale/sunshine.po | sed -e "s#\t# #g")
-          echo "git_diff=${OUTPUT}" >> $GITHUB_ENV
+          echo "git_diff=${OUTPUT}" >> "${GITHUB_ENV}"
 
       - name: git reset
         # only run if a single line changed (date/time) and file already existed
@@ -79,7 +79,7 @@ jobs:
 
       - name: Get current date
         id: date
-        run: echo "date=$(date +'%Y-%m-%d')" >> $GITHUB_OUTPUT
+        run: echo "date=$(date +'%Y-%m-%d')" >> "${GITHUB_OUTPUT}"
 
       - name: Create/Update Pull Request
         uses: peter-evans/create-pull-request@v7

cmake/packaging/linux.cmake

@@ -45,6 +45,7 @@ set(CPACK_DEBIAN_PACKAGE_DEPENDS "\
             libcap2, \
             libcurl4, \
             libdrm2, \
+            libgbm1, \
             libevdev2, \
             libnuma1, \
             libopus0, \
@@ -65,6 +66,7 @@ set(CPACK_RPM_PACKAGE_REQUIRES "\
             libva >= 2.14.0, \
             libwayland-client >= 1.20.0, \
             libX11 >= 1.7.3.1, \
+            mesa-libgbm >= 25.0.7, \
             miniupnpc >= 2.2.4, \
             numactl-libs >= 2.0.14, \
             openssl >= 3.0.2, \

cmake/prep/build_version.cmake

@@ -1,18 +1,18 @@
 # Set build variables if env variables are defined
 # These are used in configured files such as manifests for different packages
-if(DEFINED ENV{BRANCH})  # cmake-lint: disable=W0106
+if(DEFINED ENV{BRANCH})
     set(GITHUB_BRANCH $ENV{BRANCH})
 endif()
 if(DEFINED ENV{BUILD_VERSION})  # cmake-lint: disable=W0106
     set(BUILD_VERSION $ENV{BUILD_VERSION})
 endif()
-if(DEFINED ENV{CLONE_URL})  # cmake-lint: disable=W0106
+if(DEFINED ENV{CLONE_URL})
     set(GITHUB_CLONE_URL $ENV{CLONE_URL})
 endif()
-if(DEFINED ENV{COMMIT})  # cmake-lint: disable=W0106
+if(DEFINED ENV{COMMIT})
     set(GITHUB_COMMIT $ENV{COMMIT})
 endif()
-if(DEFINED ENV{TAG})  # cmake-lint: disable=W0106
+if(DEFINED ENV{TAG})
     set(GITHUB_TAG $ENV{TAG})
 endif()
 

docker/archlinux.dockerfile

@@ -32,7 +32,6 @@ ENV CLONE_URL=${CLONE_URL}
 
 SHELL ["/bin/bash", "-o", "pipefail", "-c"]
 
-# hadolint ignore=SC2016
 RUN <<_SETUP
 #!/bin/bash
 set -e
@@ -42,6 +41,7 @@ useradd -m builder
 echo 'builder ALL=(ALL) NOPASSWD: ALL' >> /etc/sudoers
 
 # patch the build flags
+# shellcheck disable=SC2016
 sed -i 's,#MAKEFLAGS="-j2",MAKEFLAGS="-j$(nproc)",g' /etc/makepkg.conf
 
 # install dependencies

docker/clion-toolchain.dockerfile

@@ -19,7 +19,6 @@ ENV DISPLAY=:0
 SHELL ["/bin/bash", "-o", "pipefail", "-c"]
 
 # install dependencies
-# hadolint ignore=SC1091
 RUN <<_DEPS
 #!/bin/bash
 set -e
@@ -74,7 +73,6 @@ WORKDIR /build/cuda
 # versions: https://developer.nvidia.com/cuda-toolkit-archive
 ENV CUDA_VERSION="11.8.0"
 ENV CUDA_BUILD="520.61.05"
-# hadolint ignore=SC3010
 RUN <<_INSTALL_CUDA
 #!/bin/bash
 set -e

docker/debian-bookworm.dockerfile

@@ -42,7 +42,6 @@ _BUILD
 
 # run tests
 WORKDIR /build/sunshine/build/tests
-# hadolint ignore=SC1091
 RUN <<_TEST
 #!/bin/bash
 set -e

docker/ubuntu-22.04.dockerfile

@@ -42,7 +42,6 @@ _BUILD
 
 # run tests
 WORKDIR /build/sunshine/build/tests
-# hadolint ignore=SC1091
 RUN <<_TEST
 #!/bin/bash
 set -e

docker/ubuntu-24.04.dockerfile

@@ -42,7 +42,6 @@ _BUILD
 
 # run tests
 WORKDIR /build/sunshine/build/tests
-# hadolint ignore=SC1091
 RUN <<_TEST
 #!/bin/bash
 set -e

docs/configuration.md

@@ -1270,7 +1270,7 @@ editing the `conf` file in a text editor. Use the examples as reference.
         <td colspan="2">
             Remap the requested resolution and FPS to another display mode.<br>
             Depending on the [dd_resolution_option](#dd_resolution_option) and
-            [dd_refresh_rate_option](#dd_refresh_rate_option) values, the following mapping 
+            [dd_refresh_rate_option](#dd_refresh_rate_option) values, the following mapping
             groups are available:
             <ul>
                 <li>`mixed` - both options are set to `auto`.</li>
@@ -1281,7 +1281,7 @@ editing the `conf` file in a text editor. Use the examples as reference.
                   `refresh_rate_only` - only [dd_refresh_rate_option](#dd_refresh_rate_option) is set to `auto`.
                 </li>
             </ul>
-            For each of those groups, a list of fields can be configured to perform remapping:  
+            For each of those groups, a list of fields can be configured to perform remapping:
             <ul>
                 <li>
                   `requested_resolution` - resolution that needs to be matched in order to use this remapping entry.
@@ -1291,10 +1291,10 @@ editing the `conf` file in a text editor. Use the examples as reference.
                 <li>`final_refresh_rate` - refresh rate value to be used if the entry was matched.</li>
             </ul>
             If `requested_*` field is left empty, it will match <b>everything</b>.<br>
-            If `final_*` field is left empty, the original value will not be remapped and either a requested, manual 
-            or current value is used. However, at least one `final_*` must be set, otherwise the entry is considered 
+            If `final_*` field is left empty, the original value will not be remapped and either a requested, manual
+            or current value is used. However, at least one `final_*` must be set, otherwise the entry is considered
             invalid.<br>
-            @note{"Optimize game settings" must be enabled on client side for ANY entry with `resolution` 
+            @note{"Optimize game settings" must be enabled on client side for ANY entry with `resolution`
             field to be considered.}
             @note{First entry to be matched in the list is the one that will be used.}
             @tip{`requested_resolution` and `final_resolution` can be omitted for `refresh_rate_only` group.}
@@ -1371,6 +1371,32 @@ editing the `conf` file in a text editor. Use the examples as reference.
     </tr>
 </table>
 
+### minimum_fps_target
+
+<table>
+    <tr>
+        <td>Description</td>
+        <td colspan="2">
+            Sunshine tries to save bandwidth when content on screen is static or a low framerate. Because many clients expect a constant stream of video frames, a certain amount of duplicate frames are sent when this happens. This setting controls the lowest effective framerate a stream can reach.
+        </td>
+    </tr>
+    <tr>
+        <td>Default</td>
+        <td colspan="2">@code{}
+            0
+            @endcode</td>
+    </tr>
+    <tr>
+        <td rowspan="3">Choices</td>
+        <td>0</td>
+        <td>Use half the stream's FPS as the minimum target.</td>
+    </tr>
+    <tr>
+        <td>1-1000</td>
+        <td>Specify your own value. The real minimum may differ from this value.</td>
+    </tr>
+</table>
+
 ## Network
 
 ### upnp

docs/troubleshooting.md

@@ -84,9 +84,35 @@ client only 1 Gbit/s or Wi-Fi. Similarly, a 1 Gbps host may be too fast for a
 client having only a 100 Mbps interface.
 
 As a workaround the transmission speed of the host NIC can be reduced: 1 Gbps
-instead of 2.5 or 100 Mbps instead of 1 Gbps. (A technically more advanced
+instead of 2.5 or 100 Mbps instead of 1 Gbps. A technically more advanced
 solution would be to configure traffic shaping rules at the OS-level, so that
-only Sunshine's traffic is slowed down.)
+only Sunshine's traffic is slowed down.
+
+Such a solution on Linux could look like that:
+
+```bash
+# 1) Remove existing qdisc (pfifo_fast)
+sudo tc qdisc del dev <NIC> root
+
+# 2) Add HTB root qdisc with default class 1:1
+sudo tc qdisc add dev <NIC> root handle 1: htb default 1
+
+# 3) Create class 1:1 for full 10 Gbit/s (all other traffic)
+sudo tc class add dev <NIC> parent 1: classid 1:1 htb \
+    rate 10000mbit ceil 10000mbit burst 32k
+
+# 4) Create class 1:10 for Sunshine game stream at 1 Gbit/s
+sudo tc class add dev <NIC> parent 1: classid 1:10 htb \
+    rate 1000mbit ceil 1000mbit burst 32k
+
+# 5) Filter UDP source port 47998 into class 1:10
+sudo tc filter add dev <NIC> protocol ip parent 1: prio 1 \
+    u32 match ip protocol 17 0xff \
+    match ip sport 47998 0xffff flowid 1:10
+```
+
+In that way only the Sunshine traffic is limited by 1 Gbit. This is not persistent on reboots.
+If you use a different port for the game stream you need to adjust the last command.
 
 Sunshine versions > 0.23.1 include improved networking code that should
 alleviate or even solve this issue (without reducing the NIC speed).

packaging/linux/fedora/Sunshine.spec

@@ -97,9 +97,6 @@ tar -xzf %{SOURCE0} -C %{_builddir}/Sunshine
 # list directory
 ls -a %{_builddir}/Sunshine
 
-# patches
-%autopatch -p1
-
 %build
 # exit on error
 set -e

packaging/linux/flatpak/scripts/additional-install.sh

@@ -2,12 +2,12 @@
 
 # User Service
 mkdir -p ~/.config/systemd/user
-cp /app/share/sunshine/systemd/user/sunshine.service $HOME/.config/systemd/user/sunshine.service
-echo Sunshine User Service has been installed.
-echo Use [systemctl --user enable sunshine] once to autostart Sunshine on login.
+cp "/app/share/sunshine/systemd/user/sunshine.service" "$HOME/.config/systemd/user/sunshine.service"
+echo "Sunshine User Service has been installed."
+echo "Use [systemctl --user enable sunshine] once to autostart Sunshine on login."
 
 # Udev rule
 UDEV=$(cat /app/share/sunshine/udev/rules.d/60-sunshine.rules)
-echo Configuring mouse permission.
+echo "Configuring mouse permission."
 flatpak-spawn --host pkexec sh -c "echo '$UDEV' > /etc/udev/rules.d/60-sunshine.rules"
-echo Restart computer for mouse permission to take effect.
+echo "Restart computer for mouse permission to take effect."

packaging/linux/flatpak/scripts/remove-additional-install.sh

@@ -2,10 +2,10 @@
 
 # User Service
 systemctl --user stop sunshine
-rm $HOME/.config/systemd/user/sunshine.service
+rm "$HOME/.config/systemd/user/sunshine.service"
 systemctl --user daemon-reload
-echo Sunshine User Service has been removed.
+echo "Sunshine User Service has been removed."
 
 # Udev rule
 flatpak-spawn --host pkexec sh -c "rm /etc/udev/rules.d/60-sunshine.rules"
-echo Input rules removed. Restart computer to take effect.
+echo "Input rules removed. Restart computer to take effect."

scripts/icons/convert_and_pack.sh

@@ -1,61 +1,63 @@
-#!/bin/bash
-
-if ! [ -x "$(command -v ./go-png2ico)" ]; then
-    echo "./go-png2ico not found"
-    echo "download the executable from https://github.com/J-Siu/go-png2ico"
-    echo "and drop it in this folder"
-    exit 1
-fi
-
-if ! [ -x "$(command -v ./oxipng)" ]; then
-    echo "./oxipng executable not found"
-    echo "download the executable from https://github.com/shssoichiro/oxipng"
-    echo "and drop it in this folder"
-    exit 1
-fi
-
-if ! [ -x "$(command -v inkscape)" ]; then
-    echo "inkscape executable not found"
-    exit 1
-fi
-
-icon_base_sizes=(16 64)
-icon_sizes_keys=() # associative array to prevent duplicates
-icon_sizes_keys[256]=1
-
-for icon_base_size in ${icon_base_sizes[@]}; do
-    # increment in 25% till 400%
-    icon_size_increment=$((icon_base_size / 4))
-    for ((i = 0; i <= 12; i++)); do
-        icon_sizes_keys[$((icon_base_size + i * icon_size_increment))]=1
-    done
-done
-
-# convert to normal array
-icon_sizes=${!icon_sizes_keys[@]}
-
-echo "using icon sizes:"
-echo ${icon_sizes[@]}
-
-src_vectors=("../../src_assets/common/assets/web/public/images/sunshine-locked.svg"
-             "../../src_assets/common/assets/web/public/images/sunshine-pausing.svg"
-             "../../src_assets/common/assets/web/public/images/sunshine-playing.svg"
-             "../../sunshine.svg")
-
-echo "using sources vectors:"
-echo ${src_vectors[@]}
-
-for src_vector in ${src_vectors[@]}; do
-    file_name=`basename "$src_vector" .svg`
-    png_files=()
-    for icon_size in ${icon_sizes[@]}; do
-        png_file="${file_name}${icon_size}.png"
-        echo "converting ${png_file}"
-        inkscape -w $icon_size -h $icon_size "$src_vector" --export-filename "${png_file}" &&
-        ./oxipng -o max --strip safe --alpha "${png_file}" &&
-        png_files+=("${png_file}")
-    done
-
-    echo "packing ${file_name}.ico"
-    ./go-png2ico "${png_files[@]}" "${file_name}.ico"
-done
+#!/bin/bash
+
+if ! [ -x "$(command -v ./go-png2ico)" ]; then
+    echo "./go-png2ico not found"
+    echo "download the executable from https://github.com/J-Siu/go-png2ico"
+    echo "and drop it in this folder"
+    exit 1
+fi
+
+if ! [ -x "$(command -v ./oxipng)" ]; then
+    echo "./oxipng executable not found"
+    echo "download the executable from https://github.com/shssoichiro/oxipng"
+    echo "and drop it in this folder"
+    exit 1
+fi
+
+if ! [ -x "$(command -v inkscape)" ]; then
+    echo "inkscape executable not found"
+    exit 1
+fi
+
+icon_base_sizes=(16 64)
+icon_sizes_keys=() # associative array to prevent duplicates
+icon_sizes_keys[256]=1
+
+for icon_base_size in "${icon_base_sizes[@]}"; do
+    # increment in 25% till 400%
+    icon_size_increment=$((icon_base_size / 4))
+    for ((i = 0; i <= 12; i++)); do
+        icon_sizes_keys[icon_base_size + i * icon_size_increment]=1
+    done
+done
+
+# convert to normal array
+icon_sizes=("${!icon_sizes_keys[@]}")
+
+echo "using icon sizes:"
+# shellcheck disable=SC2068  # intentionally word split
+echo ${icon_sizes[@]}
+
+src_vectors=("../../src_assets/common/assets/web/public/images/sunshine-locked.svg"
+             "../../src_assets/common/assets/web/public/images/sunshine-pausing.svg"
+             "../../src_assets/common/assets/web/public/images/sunshine-playing.svg"
+             "../../sunshine.svg")
+
+echo "using sources vectors:"
+# shellcheck disable=SC2068  # intentionally word split
+echo ${src_vectors[@]}
+
+for src_vector in "${src_vectors[@]}"; do
+    file_name=$(basename "${src_vector}" .svg)
+    png_files=()
+    for icon_size in "${icon_sizes[@]}"; do
+        png_file="${file_name}${icon_size}.png"
+        echo "converting ${png_file}"
+        inkscape -w "${icon_size}" -h "${icon_size}" "${src_vector}" --export-filename "${png_file}" &&
+        ./oxipng -o max --strip safe --alpha "${png_file}" &&
+        png_files+=("${png_file}")
+    done
+
+    echo "packing ${file_name}.ico"
+    ./go-png2ico "${png_files[@]}" "${file_name}.ico"
+done

scripts/linux_build.sh

@@ -460,6 +460,8 @@ function run_install() {
     nvm_url="https://raw.githubusercontent.com/nvm-sh/nvm/master/install.sh"
     echo "nvm url: ${nvm_url}"
     wget -qO- ${nvm_url} | bash
+
+    # shellcheck source=/dev/null  # we don't care that shellcheck cannot find nvm.sh
     source "$HOME/.nvm/nvm.sh"
     nvm install node
     nvm use node

src/config.cpp

@@ -504,7 +504,8 @@ namespace config {
       {}  // wa
     },  // display_device
 
-    0  // max_bitrate
+    0,  // max_bitrate
+    0  // minimum_fps_target (0 = framerate)
   };
 
   audio_t audio {
@@ -1146,6 +1147,7 @@ namespace config {
     }
 
     int_f(vars, "max_bitrate", video.max_bitrate);
+    double_between_f(vars, "minimum_fps_target", video.minimum_fps_target, {0.0, 1000.0});
 
     path_f(vars, "pkey", nvhttp.pkey);
     path_f(vars, "cert", nvhttp.cert);

src/config.h

@@ -141,6 +141,7 @@ namespace config {
     } dd;
 
     int max_bitrate;  // Maximum bitrate, sets ceiling in kbps for bitrate requested from client
+    double minimum_fps_target;  ///< Lowest framerate that will be used when streaming. Range 0-1000, 0 = half of client's requested framerate.
   };
 
   struct audio_t {

src/platform/windows/audio.cpp

@@ -5,7 +5,7 @@
 #define INITGUID
 
 // platform includes
-#include <audioclient.h>
+#include <Audioclient.h>
 #include <avrt.h>
 #include <mmdeviceapi.h>
 #include <newdev.h>
@@ -172,19 +172,19 @@ namespace {
               std::to_string(waveformat.Format.nSamplesPerSec) + " ";
 
     switch (waveformat.dwChannelMask) {
-      case (waveformat_mask_stereo):
+      case waveformat_mask_stereo:
         result += "2.0";
         break;
 
-      case (waveformat_mask_surround51_with_backspeakers):
+      case waveformat_mask_surround51_with_backspeakers:
         result += "5.1";
         break;
 
-      case (waveformat_mask_surround51_with_sidespeakers):
+      case waveformat_mask_surround51_with_sidespeakers:
         result += "5.1 (sidespeakers)";
         break;
 
-      case (waveformat_mask_surround71):
+      case waveformat_mask_surround71:
         result += "7.1";
         break;
 

src/platform/windows/display.h

@@ -12,7 +12,7 @@
 #include <dxgi.h>
 #include <dxgi1_6.h>
 #include <Unknwn.h>
-#include <winrt/Windows.Graphics.Capture.h>
+#include <winrt/windows.graphics.capture.h>
 
 // local includes
 #include "src/platform/common.h"

src/platform/windows/display_vram.cpp

@@ -7,7 +7,7 @@
 
 // platform includes
 #include <d3dcompiler.h>
-#include <directxmath.h>
+#include <DirectXMath.h>
 
 extern "C" {
 #include <libavcodec/avcodec.h>

src/platform/windows/display_wgc.cpp

@@ -13,7 +13,7 @@
 // Gross hack to work around MINGW-packages#22160
 #define ____FIReference_1_boolean_INTERFACE_DEFINED__
 
-#include <windows.graphics.capture.interop.h>
+#include <Windows.Graphics.Capture.Interop.h>
 #include <winrt/windows.foundation.h>
 #include <winrt/windows.foundation.metadata.h>
 #include <winrt/windows.graphics.directx.direct3d11.h>

src/platform/windows/input.cpp

@@ -5,7 +5,7 @@
 #define WINVER 0x0A00
 
 // platform includes
-#include <windows.h>
+#include <Windows.h>
 
 // standard includes
 #include <cmath>
@@ -1598,8 +1598,8 @@ namespace platf {
     uint16_t y = touch.y * 943;
     uint8_t touchData[] = {
       (uint8_t) (x & 0xFF),  // Low 8 bits of X
-      (uint8_t) (((x >> 8) & 0x0F) | ((y & 0x0F) << 4)),  // High 4 bits of X and low 4 bits of Y
-      (uint8_t) (((y >> 4) & 0xFF))  // High 8 bits of Y
+      (uint8_t) ((x >> 8 & 0x0F) | (y & 0x0F) << 4),  // High 4 bits of X and low 4 bits of Y
+      (uint8_t) (y >> 4 & 0xFF)  // High 8 bits of Y
     };
 
     report.sCurrentTouch.bPacketCounter++;

src/platform/windows/misc.cpp

@@ -22,13 +22,13 @@
 #include <iphlpapi.h>
 #include <iterator>
 #include <timeapi.h>
-#include <userenv.h>
-#include <winsock2.h>
-#include <windows.h>
-#include <winuser.h>
+#include <UserEnv.h>
+#include <WinSock2.h>
+#include <Windows.h>
+#include <WinUser.h>
 #include <wlanapi.h>
-#include <ws2tcpip.h>
-#include <wtsapi32.h>
+#include <WS2tcpip.h>
+#include <WtsApi32.h>
 #include <sddl.h>
 // clang-format on
 

src/platform/windows/misc.h

@@ -9,7 +9,7 @@
 #include <string_view>
 
 // platform includes
-#include <windows.h>
+#include <Windows.h>
 #include <winnt.h>
 
 namespace platf {

src/platform/windows/nvprefs/nvprefs_common.h

@@ -7,8 +7,8 @@
 // platform includes
 // disable clang-format header reordering
 // clang-format off
-#include <windows.h>
-#include <aclapi.h>
+#include <Windows.h>
+#include <AclAPI.h>
 // clang-format on
 
 // local includes

src/platform/windows/publish.cpp

@@ -3,12 +3,12 @@
  * @brief Definitions for Windows mDNS service registration.
  */
 // platform includes
-// winsock2.h must be included before windows.h
+// WinSock2.h must be included before Windows.h
 // clang-format off
-#include <winsock2.h>
-#include <windows.h>
+#include <WinSock2.h>
+#include <Windows.h>
 // clang-format on
-#include <windns.h>
+#include <WinDNS.h>
 #include <winerror.h>
 
 // local includes

src/process.cpp

@@ -158,7 +158,7 @@ namespace proc {
     _env["SUNSHINE_CLIENT_GCMAP"] = std::to_string(launch_session->gcmap);
     _env["SUNSHINE_CLIENT_HOST_AUDIO"] = launch_session->host_audio ? "true" : "false";
     _env["SUNSHINE_CLIENT_ENABLE_SOPS"] = launch_session->enable_sops ? "true" : "false";
-    int channelCount = launch_session->surround_info & (65535);
+    int channelCount = launch_session->surround_info & 65535;
     switch (channelCount) {
       case 2:
         _env["SUNSHINE_CLIENT_AUDIO_CONFIGURATION"] = "2.0";

src/video.cpp

@@ -1890,9 +1890,10 @@ namespace video {
       }
     });
 
-    // set minimum frame time based on client-requested target framerate
-    std::chrono::duration<double, std::milli> minimum_frame_time {1000.0 / config.framerate};
-    BOOST_LOG(info) << "Minimum frame time set to "sv << minimum_frame_time.count() << "ms, based on client-requested target framerate "sv << config.framerate << "."sv;
+    // set max frame time based on client-requested target framerate.
+    double minimum_fps_target = (config::video.minimum_fps_target > 0.0) ? config::video.minimum_fps_target : config.framerate;
+    std::chrono::duration<double, std::milli> max_frametime {1000.0 / minimum_fps_target};
+    BOOST_LOG(info) << "Minimum FPS target set to ~"sv << (minimum_fps_target / 2) << "fps ("sv << max_frametime.count() * 2 << "ms)"sv;
 
     auto shutdown_event = mail->event<bool>(mail::shutdown);
     auto packets = mail::man->queue<packet_t>(mail::video_packets);
@@ -1943,7 +1944,7 @@ namespace video {
 
       // Encode at a minimum FPS to avoid image quality issues with static content
       if (!requested_idr_frame || images->peek()) {
-        if (auto img = images->pop(minimum_frame_time)) {
+        if (auto img = images->pop(max_frametime)) {
           frame_timestamp = img->frame_timestamp;
           if (session->convert(*img)) {
             BOOST_LOG(error) << "Could not convert image"sv;

src_assets/common/assets/web/config.html

@@ -179,6 +179,7 @@
               "dd_mode_remapping": {"mixed": [], "resolution_only": [], "refresh_rate_only": []},
               "dd_wa_hdr_toggle_delay": 0,
               "max_bitrate": 0,
+              "minimum_fps_target": 0
             },
           },
           {

src_assets/common/assets/web/configs/tabs/audiovideo/DisplayModesSettings.vue

@@ -17,6 +17,13 @@ const config = ref(props.config)
     <input type="number" class="form-control" id="max_bitrate" placeholder="0" v-model="config.max_bitrate" />
     <div class="form-text">{{ $t("config.max_bitrate_desc") }}</div>
   </div>
+
+  <!--minimum_fps_target-->
+  <div class="mb-3">
+    <label for="minimum_fps_target" class="form-label">{{ $t("config.minimum_fps_target") }}</label>
+    <input type="number" min="0" max="1000" class="form-control" id="minimum_fps_target" placeholder="0" v-model="config.minimum_fps_target" />
+    <div class="form-text">{{ $t("config.minimum_fps_target_desc") }}</div>
+  </div>
 </template>
 
 <style scoped>

src_assets/common/assets/web/public/assets/locale/en.json

@@ -256,6 +256,8 @@
     "log_path_desc": "The file where the current logs of Sunshine are stored.",
     "max_bitrate": "Maximum Bitrate",
     "max_bitrate_desc": "The maximum bitrate (in Kbps) that Sunshine will encode the stream at. If set to 0, it will always use the bitrate requested by Moonlight.",
+    "minimum_fps_target": "Minimum FPS Target",
+    "minimum_fps_target_desc": "The lowest effective FPS a stream can reach. A value of 0 is treated as roughly half of the stream's FPS. A setting of 20 is recommended if you stream 24 or 30fps content.",
     "min_threads": "Minimum CPU Thread Count",
     "min_threads_desc": "Increasing the value slightly reduces encoding efficiency, but the tradeoff is usually worth it to gain the use of more CPU cores for encoding. The ideal value is the lowest value that can reliably encode at your desired streaming settings on your hardware.",
     "misc": "Miscellaneous options",

src_assets/macos/misc/uninstall_pkg.sh

@@ -27,7 +27,8 @@ for dir in ${DIRECTORIES}; do
 
     # remove the directory if it is empty
     if [[ $empty_dir != "" ]]; then  # prevent the loop from running and failing if no directories found
-        for i in "${empty_dir}"; do  # don't split words as we already know this will be a single directory
+        # shellcheck disable=SC2066  # don't split words as we already know this will be a single directory
+        for i in "${empty_dir}"; do
             echo "Removing empty directory: ${i}"
             rmdir "${i}"
         done

tools/audio.cpp

@@ -5,7 +5,7 @@
 #define INITGUID
 
 // platform includes
-#include <audioclient.h>
+#include <Audioclient.h>
 #include <codecvt>
 #include <iostream>
 #include <locale>

tools/sunshinesvc.cpp

@@ -5,7 +5,7 @@
 #define WIN32_LEAN_AND_MEAN
 #include <string>
 #include <Windows.h>
-#include <wtsapi32.h>
+#include <WtsApi32.h>
 
 // PROC_THREAD_ATTRIBUTE_JOB_LIST is currently missing from MinGW headers
 #ifndef PROC_THREAD_ATTRIBUTE_JOB_LIST