Merge pull request #1366 from houqp/fix_1354

fix: empty item_table crashes menu widget

frontend/ui/widget/menu.lua

@@ -604,7 +604,7 @@ function Menu:updateItems(select_number)
         select_number = 1
     end
 
-    for c = 1, self.perpage do
+    for c = 1, math.min(self.perpage, #self.item_table) do
         -- calculate index in item_table
         local i = (self.page - 1) * self.perpage + c
         if i <= #self.item_table then

spec/unit/imagewidget_spec.lua

@@ -0,0 +1,20 @@
+require("commonrequire")
+local ImageWidget = require("ui/widget/imagewidget")
+
+describe("ImageWidget module", function()
+    it("should render without error", function()
+        local imgw = ImageWidget:new{
+            file = "resources/icons/appbar.chevron.up.png"
+        }
+        imgw:_render()
+        assert(imgw._bb)
+    end)
+    it("should error out on none exist image", function()
+        local imgw = ImageWidget:new{
+            file = "wtf.png"
+        }
+        assert.has_error(function()
+            imgw:_render()
+        end)
+    end)
+end)

spec/unit/readerui_spec.lua

@@ -3,7 +3,6 @@ local DocumentRegistry = require("document/documentregistry")
 local ReaderUI = require("apps/reader/readerui")
 local DocSettings = require("docsettings")
 local UIManager = require("ui/uimanager")
-local DEBUG = require("dbg")
 
 describe("Readerui module", function()
     local sample_epub = "spec/front/unit/data/leaves.epub"