renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix ConfigDialog's ButtonProgress Fine tune updating presets (#6433)

Browse Source 
Witnessed with "L/R Margins": tapping on a button
sets the value to the preset table, by reference.
Tapping the -/+ fine tuning buttons was updating
these tables in-place, in effect modifying the presets.
This commit is contained in:
poire-z
2020-07-25 23:15:31 +02:00
committed by GitHub
parent 4c70e6cb56
commit 1c49f817fd
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
frontend/ui/widget/configdialog.lua
View File

@@ -997,12 +997,17 @@ function ConfigDialog:onConfigFineTuneChoose(values, name, event, args, events,
if direction == "-" then
value = self.configurable[name] or values[1]
if type(value) == "table" then
-- Don't update directly this table: it might be a reference
-- to one of the original preset values tables
local updated = {}
for i=1, #value do
value[i] = value[i] - 1
if value[i] < 0 then
value[i] = 0
local v = value[i] - 1
if v < 0 then
v = 0
end
table.insert(updated, v)
end
value = updated
else
value = value - 1
if value < 0 then
@@ -1012,9 +1017,11 @@ function ConfigDialog:onConfigFineTuneChoose(values, name, event, args, events,
else
value = self.configurable[name] or values[#values]
if type(value) == "table" then
local updated = {}
for i=1, #value do
value[i] = value[i] + 1
table.insert(updated, value[i] + 1)
end
value = updated
else
value = value + 1
end