Menu: remove "Show advanced options"

See #2610 for discussion.

frontend/ui/elements/common_settings_menu_table.lua

@@ -76,15 +76,5 @@ common_settings.save_document = {
     },
 }
 common_settings.language = Language:getLangMenuTable()
-common_settings.show_advanced_options = {
-    text = _("Show advanced options"),
-    checked_func = function() return G_reader_settings:readSetting("show_advanced") end,
-    callback = function()
-        local show_advanced = G_reader_settings:readSetting("show_advanced") or false
-        G_reader_settings:saveSetting("show_advanced", not show_advanced)
-    end
-}
-
-
 
 return common_settings

frontend/ui/elements/filemanager_menu_order.lua

@@ -24,8 +24,6 @@ local order = {
         "save_document",
         "----------------------------",
         "language",
-        "----------------------------",
-        "show_advanced_options",
         -- end common settings
     },
     tools = {

frontend/ui/elements/reader_menu_order.lua

@@ -40,7 +40,6 @@ local order = {
         "----------------------------",
         "djvu_render_mode",
         "status_bar",
-        "show_advanced_options",
     },
     tools = {
         "calibre_wireless_connection",

frontend/ui/widget/configdialog.lua

@@ -163,7 +163,9 @@ function ConfigOption:init()
     table.insert(vertical_group, VerticalSpan:new{
         width = Screen:scaleBySize(default_option_padding),
     })
-    local show_advanced = G_reader_settings:readSetting("show_advanced") or false
+    -- @TODO restore setting when there are more advanced settings
+    --local show_advanced = G_reader_settings:readSetting("show_advanced") or false
+    local show_advanced = true
     for c = 1, #self.options do
         local show_default = not self.options[c].advanced or show_advanced
         if self.options[c].show ~= false and show_default then