renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

TouchMenu: Abort early if tap/hold handlers are called on an unpainted

Browse Source 
widget

May happen if we have blocking stuff on startup (e.g., Wi-Fi), and you
spam tap the screen during the white screen.
This commit is contained in:
NiLuJe
2021-06-18 19:23:03 +02:00
parent c7232af8eb
commit 240a4acdcc
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
frontend/ui/widget/touchmenu.lua
View File

@@ -157,6 +157,9 @@ function TouchMenuItem:onTapSelect(arg, ges)
end
if enabled == false then return end
-- If the menu hasn't actually been drawn yet, don't do anything (as it's confusing, and the coordinates may be wrong).
if not self.item_frame.dimen then return end
if G_reader_settings:isFalse("flash_ui") then
self.menu:onMenuSelect(self.item)
else
@@ -200,6 +203,8 @@ function TouchMenuItem:onHoldSelect(arg, ges)
end
if enabled == false then return end
if not self.item_frame.dimen then return end
if G_reader_settings:isFalse("flash_ui") then
self.menu:onMenuHold(self.item, self.text_truncated)
else