Merge pull request #962 from chrox/coverage

coverage test only sources from frontend and plugins

.busted

@@ -2,5 +2,6 @@ return {
 	default = {
 		verbose = true,
 		ROOT = "spec/front/unit",
+		lpath = "spec/front/unit/?.lua",
 	},
 }

.luacov

@@ -25,6 +25,8 @@ return {
   -- (exclude overrules include, do not include
   -- the .lua extension)
   ['include'] = {
+    'frontend/.*$',
+    'plugins/.*$',
   },
 
   -- Patterns for files to exclude when reporting

frontend/docsettings.lua

@@ -146,4 +146,13 @@ function DocSettings:close()
     self:flush()
 end
 
+function DocSettings:clear()
+    if self.history_file then
+        os.remove(self.history_file)
+    end
+    if self.sidecar_file then
+        os.remove(self.sidecar_file)
+    end
+end
+
 return DocSettings

spec/unit/benchmark.lua

@@ -1,22 +1,6 @@
-require "defaults"
-package.path = "?.lua;common/?.lua;frontend/?.lua"
-package.cpath = "?.so;common/?.so;/usr/lib/lua/?.so"
-
--- global einkfb for Screen
-einkfb = require("ffi/framebuffer")
--- do not show SDL window
-einkfb.dummy = true
-Blitbuffer = require("ffi/blitbuffer")
-
-local Screen = require("ui/screen")
-local DocSettings = require("docsettings")
-G_reader_settings = DocSettings:open(".reader")
+require("commonrequire")
 local DocumentRegistry = require("document/documentregistry")
 local util = require("ffi/util")
-local DEBUG = require("dbg")
-
--- screen should be inited for crengine
-Screen:init()
 
 function logDuration(filename, pageno, dur)
     local file = io.open(filename, "a+")

spec/unit/cache_spec.lua

@@ -1,24 +1,7 @@
-require "defaults"
-package.path = "?.lua;common/?.lua;frontend/?.lua;" .. package.path
-package.cpath = "?.so;common/?.so;/usr/lib/lua/?.so;" .. package.cpath
-
-require "libs/libkoreader-lfs"
--- global einkfb for Screen
-einkfb = require("ffi/framebuffer")
--- do not show SDL window
-einkfb.dummy = true
-Blitbuffer = require("ffi/blitbuffer")
-
-local Screen = require("ui/screen")
-local DocSettings = require("docsettings")
-G_reader_settings = DocSettings:open(".reader")
+require("commonrequire")
 local DocumentRegistry = require("document/documentregistry")
 local Cache = require("cache")
 local DEBUG = require("dbg")
---DEBUG:turnOn()
-
--- screen should be inited for crengine
-Screen:init()
 
 describe("Cache module", function()
     local sample_pdf = "spec/front/unit/data/sample.pdf"

spec/unit/commonrequire.lua

@@ -0,0 +1,23 @@
+require "defaults"
+package.path = "?.lua;common/?.lua;frontend/?.lua;" .. package.path
+package.cpath = "?.so;common/?.so;/usr/lib/lua/?.so;" .. package.cpath
+
+-- global reader settings
+local DocSettings = require("docsettings")
+G_reader_settings = DocSettings:open(".reader")
+
+-- global einkfb for Screen (do not show SDL window)
+einkfb = require("ffi/framebuffer")
+einkfb.dummy = true
+
+-- init output device
+local Screen = require("ui/screen")
+Screen:init()
+
+-- init input device (do not show SDL window)
+local Input = require("ui/input")
+Input.dummy = true
+
+-- turn on debug
+local DEBUG = require("dbg")
+DEBUG:turnOn()

spec/unit/document_spec.lua

@@ -1,20 +1,5 @@
-require "defaults"
-package.path = "?.lua;common/?.lua;frontend/?.lua;" .. package.path
-package.cpath = "?.so;common/?.so;/usr/lib/lua/?.so;" .. package.cpath
-
--- global einkfb for Screen
-einkfb = require("ffi/framebuffer")
--- do not show SDL window
-einkfb.dummy = true
-
-local Screen = require("ui/screen")
-local DocSettings = require("docsettings")
-G_reader_settings = DocSettings:open(".reader")
+require("commonrequire")
 local DocumentRegistry = require("document/documentregistry")
-local DEBUG = require("dbg")
-
--- screen should be inited for crengine
-Screen:init()
 
 describe("PDF document module", function()
     local sample_pdf = "spec/front/unit/data/tall.pdf"

spec/unit/opdsparser_spec.lua

@@ -155,16 +155,15 @@ Title:
 </feed>
 ]]
 
-package.path = "?.lua;common/?.lua;frontend/?.lua;" .. package.path
-
+require("commonrequire")
 local OPDSParser = require("ui/opdsparser")
 local DEBUG = require("dbg")
-DEBUG:turnOn()
 
 describe("OPDS parser module #nocov", function()
     it("should parse OPDS navigation catalog", function()
         local catalog = OPDSParser:parse(navigation_sample)
         local feed = catalog.feed
+        --DEBUG(feed)
         assert.truthy(feed)
         assert.are.same(feed.title, "Project Gutenberg")
         local entries = feed.entry

spec/unit/readerui_spec.lua

@@ -0,0 +1,28 @@
+require("commonrequire")
+local DocumentRegistry = require("document/documentregistry")
+local ReaderUI = require("apps/reader/readerui")
+local DocSettings = require("docsettings")
+local DEBUG = require("dbg")
+
+describe("Readerui module", function()
+    local sample_epub = "spec/front/unit/data/leaves.epub"
+    local readerui = ReaderUI:new{
+        document = DocumentRegistry:openDocument(sample_epub),
+    }
+    it("should save settings", function()
+        -- remove history settings and sidecar settings
+        DocSettings:open(sample_epub):clear()
+        local doc_settings = DocSettings:open(sample_epub)
+        assert.are.same(doc_settings.data, {})
+        readerui:saveSettings()
+        assert.are_not.same(readerui.doc_settings.data, {})
+        doc_settings = DocSettings:open(sample_epub)
+        assert.truthy(doc_settings.data.last_xpointer)
+        assert.are.same(doc_settings.data.last_xpointer,
+                readerui.doc_settings.data.last_xpointer)
+    end)
+    it("should close document", function()
+        readerui:closeDocument()
+        assert(readerui.document == nil)
+    end)
+end)