renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[fix, spec] re-enable ReaderView tests (#4970)

Browse Source 
It's not clear to me where the value is set as expected when running all tests linearly because it doesn't seem to be ReaderFooter.
This commit is contained in:
Frans de Jonge
2019-04-25 17:44:03 +02:00
committed by GitHub
parent e869041632
commit 4dc116ed6a
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
spec/unit/readerview_spec.lua
View File

@@ -47,8 +47,9 @@ describe("Readerview module", function()
end
end)
-- TODO FIX THESE TESTS THEY'RE BROKEN!!!
it("should return and restore view context in page mode #notest", function()
it("should return and restore view context in page mode", function()
-- we don't want a footer for this test
G_reader_settings:saveSetting("reader_footer_mode", 0)
local sample_pdf = "spec/front/unit/data/2col.pdf"
local readerui = ReaderUI:new{
document = DocumentRegistry:openDocument(sample_pdf),
@@ -94,9 +95,12 @@ describe("Readerview module", function()
assert.is.same(view.state.page, 2)
assert.is.same(view.visible_area.x, 0)
assert.is.same(view.visible_area.y, 10)
G_reader_settings:delSetting("reader_footer_mode")
end)
it("should return and restore view context in scroll mode #notest", function()
it("should return and restore view context in scroll mode", function()
-- we don't want a footer for this test
G_reader_settings:saveSetting("reader_footer_mode", 0)
local sample_pdf = "spec/front/unit/data/2col.pdf"
local readerui = ReaderUI:new{
document = DocumentRegistry:openDocument(sample_pdf),
@@ -142,5 +146,6 @@ describe("Readerview module", function()
assert.is.same(view.page_states[1].page, 2)
assert.is.same(view.page_states[1].visible_area.x, 0)
assert.is.same(view.page_states[1].visible_area.y, 10)
G_reader_settings:delSetting("reader_footer_mode")
end)
end)