renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Misc: Forgot to update that comment given the latest VirtualKey tweaks

Browse Source 
;).
This commit is contained in:
NiLuJe
2024-01-16 05:19:21 +01:00
parent 43d36b2ea9
commit 55171212c3
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
frontend/ui/widget/inputdialog.lua
View File

@@ -489,11 +489,11 @@ function InputDialog:onTap(arg, ges)
return
end
if self:isKeyboardVisible() then
-- NOTE: If you're unlucky enough to tap inside of a border between keys,
-- this falls outside of the ges_events range of a VirtualKey, so it is *NOT* caught by VK.
-- Instead, since we're flagged is_always_active, it goes to us,
-- so we'll have to double check that it wasn't inside of the whole VK region,
-- otherwise tapping inside a border would close the VK ;p.
-- NOTE: While VirtualKey will attempt to cover the gap between keys in its hitbox (i.e., the grey border),
-- a tap *may* still fall outside of the ges_events range of a VirtualKey (e.g., on the very edges of the board's frame).
-- In which case, since we're flagged is_always_active, it goes to us,
-- so we'll have to double check that it wasn't inside of the whole VirtualKeyboard region,
-- otherwise we'd risk spuriously closing the keyboard ;p.
-- Poke at keyboard_frame directly, as the top-level dimen never gets updated coordinates...
if self._input_widget.keyboard and self._input_widget.keyboard.dimen and ges.pos:notIntersectWith(self._input_widget.keyboard.dimen) then
self:onCloseKeyboard()