renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

CoverBrowser: list mode: better default for files_per_page (#5551)

Browse Source 
Don't use a hardcoded default value of 10 files per page, but
compute it from available height, as previously (this reverts
a bit from 0ecf42e9).
This commit is contained in:
poire-z
2019-10-31 12:06:21 +01:00
committed by GitHub
parent a5419439ce
commit 602a821acc
2 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
plugins/coverbrowser.koplugin/listmenu.lua
View File

@@ -788,13 +788,20 @@ function ListMenu:_recalculateDimen()
end
local available_height = self.dimen.h - self.others_height - Size.line.thin
-- (perpage used to be static and computed from a base of 64px per ListMenuItem,
-- which gave 10 items both in filemanager and history on kobo glo hd - now that
-- we can change the nb of items, let's start with a default of 10 - as it must
-- be known as the initial value by the menu selection widget, but there is not
-- enough information there to compute it as we could here).
-- local default_per_page = math.floor(available_height / scale_by_size / 64)
self.perpage = BookInfoManager:getSetting("files_per_page") or 10
-- (Note: we can't assign directly to self.perpage and expect it to
-- be 'nil' if it was not defined, as we'll find instead the value
-- defined in the Menu class (14) because of inheritance.)
local files_per_page = BookInfoManager:getSetting("files_per_page")
if files_per_page then
self.perpage = files_per_page
else
-- perpage used to be static and computed from a base of 64px per ListMenuItem,
-- which gave 10 items both in filemanager and history on kobo glo hd.
-- Now that we can change the nb of items, let's start with a similar default
-- and save it so it's known as the initial value by the menu selection widget.
self.perpage = math.floor(available_height / scale_by_size / 64)
BookInfoManager:saveSetting("files_per_page", self.perpage)
end
self.cover_sizetag = "s" .. self.perpage
if Screen:getWidth() > Screen:getHeight() then -- landscape mode
-- When in landscape mode (only possible with History), adjust

3
plugins/coverbrowser.koplugin/main.lua
View File

@@ -346,6 +346,9 @@ function CoverBrowser:addToMainMenu(menu_items)
keep_menu_open = true,
callback = function()
local SpinWidget = require("ui/widget/spinwidget")
-- "files_per_page" should have been saved with an adequate value
-- the first time Detailed list was shown. Fallback to a start
-- value of 10 if it hasn't.
local curr_items = BookInfoManager:getSetting("files_per_page") or 10
local items = SpinWidget:new{
width = Screen:getWidth() * 0.6,