renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ReaderStatistics: fix sync sql command (#9811)

Browse Source 
Fixes sync sql command that uses left join instead of
inner join, which adds unnecessary comparisons and
might result in incorrect mapping between databases.
This commit is contained in:
weijiuqiao
2022-11-20 07:53:18 +08:00
committed by GitHub
parent fc19b3ded7
commit 81b2f22b04
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/statistics.koplugin/main.lua
View File

@@ -2825,8 +2825,8 @@ function ReaderStatistics.onSync(local_path, cached_path, income_path)
-- We create a book_id mapping temp table (view not possible due to attached db)
CREATE TEMP TABLE book_id_map AS
SELECT m.id as mid, ifnull(i.id, m.id) as iid FROM book m --main
LEFT JOIN income_db.book i
SELECT m.id as mid, i.id as iid FROM book m --main
INNER JOIN income_db.book i
ON (m.title, m.authors, m.md5) = (i.title, i.authors, i.md5);
]]
if attached_cache then
@@ -2835,7 +2835,7 @@ function ReaderStatistics.onSync(local_path, cached_path, income_path)
-- DELETE stat_data items
DELETE FROM income_db.page_stat_data WHERE (id_book, page, start_time) IN (
SELECT map.iid, page, start_time FROM cached_db.page_stat_data
LEFT JOIN book_id_map AS map ON id_book = map.mid
INNER JOIN book_id_map AS map ON id_book = map.mid
WHERE (id_book, page, start_time) NOT IN (
SELECT id_book, page, start_time FROM page_stat_data
)