renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ReaderStatistics: reset stack/link on showing first widget

Browse Source 
Reset self.kv stack/link on showing first widget.
This avoids return arrow to possibly show previously
displayed old and unrelated KeyValuePage.
Note: when closing a leaf KeyValuePage, the previous
one will leak as self.kv.
This commit is contained in:
poire-z
2022-01-31 19:18:40 +01:00
parent 67b17d0845
commit 83172d62ae
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
plugins/statistics.koplugin/main.lua
View File

@@ -1056,10 +1056,11 @@ The max value ensures a page you stay on for a long time (because you fell aslee
text = _("Current book"),
keep_menu_open = true,
callback = function()
UIManager:show(KeyValuePage:new{
self.kv = KeyValuePage:new{
title = _("Current statistics"),
kv_pairs = self:getCurrentStat()
})
}
UIManager:show(self.kv)
end,
enabled_func = function() return not self:isDocless() and self.settings.is_enabled end,
},
@@ -2448,6 +2449,7 @@ end
function ReaderStatistics:onShowCalendarView()
self:insertDB()
self.kv = nil -- clean left over stack link
local CalendarView = require("calendarview")
UIManager:show(CalendarView:new{
reader_statistics = self,
@@ -2569,11 +2571,11 @@ end
function ReaderStatistics:onShowBookStats()
if self:isDocless() or not self.settings.is_enabled then return end
local stats = KeyValuePage:new{
self.kv = KeyValuePage:new{
title = _("Current statistics"),
kv_pairs = self:getCurrentStat()
}
UIManager:show(stats)
UIManager:show(self.kv)
end
function ReaderStatistics:getCurrentBookReadPages()