renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Reader: do not apply line spacing out of range (#10307)

Browse Source 
* readercoptlistener: fix line spacing out of range

* readerkoptlistener: fix line spacing out of range

* creoptions: fix line spacing limit
This commit is contained in:
hius07
2023-04-13 21:43:04 +03:00
committed by GitHub
parent 34c2dab54b
commit be7d6008d1
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/apps/reader/modules/readercoptlistener.lua
View File

@@ -69,9 +69,9 @@ function ReaderCoptListener:onReadSettings(config)
end
function ReaderCoptListener:onConfigChange(option_name, option_value)
-- font_size is historically and sadly shared by both mupdf and cre reader modules,
-- font_size and line_spacing are historically and sadly shared by both mupdf and cre reader modules,
-- but fortunately they can be distinguished by their different ranges
if option_name == "font_size" and option_value < 5 then return end
if (option_name == "font_size" or option_name == "line_spacing") and option_value < 5 then return end
self.document.configurable[option_name] = option_value
self.ui:handleEvent(Event:new("StartActivityIndicator"))
return true

4
frontend/apps/reader/modules/readerkoptlistener.lua
View File

@@ -72,9 +72,9 @@ function ReaderKoptListener:onDocLangUpdate(lang)
end
function ReaderKoptListener:onConfigChange(option_name, option_value)
-- font_size is historically and sadly shared by both mupdf and cre reader modules,
-- font_size and line_spacing are historically and sadly shared by both mupdf and cre reader modules,
-- but fortunately they can be distinguished by their different ranges
if option_name == "font_size" and option_value > 5 then return end
if (option_name == "font_size" or option_name == "line_spacing") and option_value > 5 then return end
self.document.configurable[option_name] = option_value
self.ui:handleEvent(Event:new("StartActivityIndicator"))
UIManager:setDirty("all", "partial")

2
frontend/ui/data/creoptions.lua
View File

@@ -387,7 +387,7 @@ Note that your selected font size is not affected by this setting.]]),
more_options = true,
more_options_param = {
value_min = 50,
value_max = 300,
value_max = 200,
value_step = 1,
value_hold_step = 5,
unit = "%",