Tigran Aivazian
29b1ef5dde
Cleanup of expandAllTOCSubItems().
2012-09-14 21:43:23 +01:00
Tigran Aivazian
922b53ac60
Cleanup of cleanUpTocTitle() function: (f(x)) is a more elegant way of forcing
...
the return of a single value than the use of a dummy variable.
2012-09-14 21:27:06 +01:00
{Qingping,Dave} Hou
b96edf3693
Merge pull request #279 from tigran123/master
...
Calculator: make it more robust.
2012-09-14 10:23:10 -07:00
Tigran Aivazian
4f2be7a7e8
Calculator: make it more robust. Previously it was very easy to crash
...
the application by entering invalid input into calculator, for example
things like these: ")(", "inf/0", "f()", etc.
By using Lua pcall() function to execute not only the construction of
the expression, but also the calculation of the final result, the calculator
is made more robust and safe-guarded from such crashes.
2012-09-14 18:36:55 +01:00
Tigran Aivazian
da296e2e95
Slight cleanup of the previous commit: save one arithmetical operation.
2012-09-14 18:10:21 +01:00
Tigran Aivazian
b6a429a1d4
Calculator: calculate the cursor position correctly when the output contains more characters than input.
2012-09-14 18:03:43 +01:00
Tigran Aivazian
dc473e85a9
Calculator: on exit from help page refresh the screen properly (i.e. fully)
2012-09-14 17:38:02 +01:00
Tigran Aivazian
b0febe2d9b
Calculator: don't crash when pressing Enter or FW-select buttons.
2012-09-14 17:24:38 +01:00
{Qingping,Dave} Hou
98b8399692
Merge pull request #278 from tigran123/master
...
Stop calculator from crashing on empty input.
2012-09-14 09:20:18 -07:00
Tigran Aivazian
3984355c1c
Part of the previous commit, i.e. "expand all subitems" in TOC.
2012-09-14 14:25:15 +01:00
Tigran Aivazian
8312ad83c5
Add "expand all" command attached to Shift-Right key in the menu which recursively expands all subitems of a given item.
2012-09-14 13:54:33 +01:00
Tigran Aivazian
e35a828fb0
Generate expandable TOC only if there really is something to expand in the TOC.
2012-09-14 09:08:47 +01:00
{Qingping,Dave} Hou
f9b8ee0513
Merge pull request #272 from tigran123/master
...
The fix for the bug issue #269 .
2012-09-10 20:24:56 -07:00
Tigran Aivazian
49a76330ac
Bugfix for the issue #269 and also fixed findTOCpos() function to correctly calculate the position in TOC
...
for the case when the current page is before the first page with a TOC entry.
2012-09-10 23:36:58 +01:00
Tigran Aivazian
1c32a24450
1. Shorten the "No TOC" message to be displayable.
...
2. Get rid of the calls to self:fillToc() from the places in the code which cannot affect TOC.
I assume the reason for these calls is that they are needed in the original CoolReader application
(because there the TOC displays the virtual "page numbers") and were brought over to our crengine.lua
during the port.
2012-09-10 23:12:09 +01:00
Dobrica Pavlinušić
44d9daf07a
Merge pull request #271 from tigran123/master
...
TOC cleanup in crengine.lua
2012-09-10 14:31:32 -07:00
{Qingping,Dave} Hou
75d286257f
Merge pull request #270 from tigran123/master
...
When renaming a file no need to initialize oldname TWICE.
2012-09-10 09:49:41 -07:00
Tigran Aivazian
253a0829ff
No need to initialize oldname = self:FullFileName() twice when renaming a file --- one initialization is enough.
...
(and, while at it, replaced references to a non-existent word "extention" with the proper English "extension")
2012-09-10 18:17:50 +01:00
Dobrica Pavlinušić
bfc369062e
Merge pull request #268 from houqp/master
...
set crengine cache size in lua code
2012-09-10 08:16:28 -07:00
Qingping Hou
1eb7162796
set crengine cache size in lua code
2012-09-10 21:45:05 +08:00
{Qingping,Dave} Hou
275e94c7a3
Merge pull request #267 from dpavlin/crengine_64Mb_cache
...
use 64Mb for on disk DOM cache for crengine
2012-09-10 06:26:38 -07:00
Dobrica Pavlinusic
880374f5db
use 64Mb for on disk DOM cache for crengine
...
Previously we had cache size limit of 100 bytes, so crengine would erase
all on-disk cache on each file open as described in #206
2012-09-10 13:42:47 +02:00
{Qingping,Dave} Hou
4cdbcac458
Merge pull request #266 from tigran123/master
...
Shorten the message about opening the document.
2012-09-09 16:05:54 -07:00
Tigran Aivazian
47556b5562
Shorten the message about opening the document, otherwise it is not displayed at all.
2012-09-10 00:16:06 +01:00
Dobrica Pavlinusic
397d3aa037
Merge branch 'gamma_speedup'
2012-09-09 21:44:09 +02:00
Dobrica Pavlinusic
2332691bb0
replaced showInfoMsgWithDelay with InfoMessage:show in crereader
2012-09-09 21:41:35 +02:00
{Qingping,Dave} Hou
0100f33128
Merge pull request #264 from dpavlin/gamma_speedup
...
showInfoMsgWithDelay would delay gamma change for 1s #165
2012-09-09 12:39:39 -07:00
{Qingping,Dave} Hou
79a304bb5d
Merge pull request #262 from dpavlin/render_indicator
...
added page_indicator to show document position and rendering
2012-09-09 12:38:13 -07:00
Dobrica Pavlinusic
b27b665a97
showInfoMsgWithDelay would delay gamma change for 1s #165
2012-09-09 21:05:23 +02:00
Dobrica Pavlinušić
b75470365b
Merge pull request #263 from tigran123/master
...
Allow deleting bookmarks as requested in issue #256
2012-09-09 11:56:01 -07:00
Tigran Aivazian
4242cc9686
Allow deleting bookmarks.
2012-09-09 19:46:24 +01:00
Dobrica Pavlinusic
4e1586fc81
added page_indicator to show document position and rendering
...
idea is simple: when starting long operation (page renedering) invert
box on top of screen which has relative width of this page.
This allows easy overview where in document user is, along with
indication that something is still happending.
Perfect use-case are glossy magazines pdfs which have first two
pages in hi-res graphics, so this indicator is very useful to see
that something is still happending and that reader didn't die
2012-09-09 19:06:15 +02:00
{Qingping,Dave} Hou
af53a78291
Merge pull request #260 from tigran123/master
...
Slight tidy up to the fix for \#257
2012-09-09 06:35:18 -07:00
Tigran Aivazian
2c6dfae807
Shorten various messages --- otherwise they are NOT SHOWN at all.
...
Also, mark pagedirty in all cases when deleting the file, to cause the screen refresh --
otherwise the message "Press 'Y' to confirm" stays there indefinitely.
2012-09-09 15:08:46 +01:00
Tigran Aivazian
f1e197cbfd
For documents without TOC we need to redraw current page after showing the "No Table of Contents" message,
...
otherwise the message "Retrieving TOC..." will stay on the screen indefinitely.
2012-09-09 15:00:17 +01:00
{Qingping,Dave} Hou
329132d3df
Merge pull request #259 from dpavlin/fileinfo_duplication
...
fileinfo doesn't reset results
2012-09-09 06:33:48 -07:00
{Qingping,Dave} Hou
7e20d120db
Merge pull request #258 from dpavlin/cr_cache
...
use ldomDocCache::init to cache crengine DOM
2012-09-09 06:32:28 -07:00
Dobrica Pavlinušić
4c5f488151
Merge pull request #257 from dpavlin/master
...
fix crash on documents without TOC
2012-09-09 04:21:06 -07:00
Dobrica Pavlinusic
d3aa98abb9
fileinfo doesn't reset results
...
This affects multiple entry into fileinfo which just accumulate
information, eventually scrolling off screen
2012-09-09 13:13:12 +02:00
Dobrica Pavlinusic
3fe518979c
use ldomDocCache::init to cache crengine DOM
...
This should improve performance of crengine #206
2012-09-09 12:58:04 +02:00
Dobrica Pavlinusic
acc61e7c07
fix crash on documents without TOC
...
Showing TOC on documents without one results in following error:
lua config error: ./unireader.lua:1742: attempt to get length of a nil value
2012-09-09 12:19:59 +02:00
{Qingping,Dave} Hou
9c0b59c79e
Merge pull request #255 from tigran123/master
...
Multi-level TOC support.
2012-09-08 17:09:26 -07:00
Qingping Hou
6a1de042f4
initialize fileinfo.commands to nil
2012-09-09 08:08:48 +08:00
Tigran Aivazian
27340db68b
cleanup: get rid of the variable that is no longer needed.
2012-09-09 01:00:43 +01:00
Tigran Aivazian
44df8027f7
Fix the function cleanUpTocTitle() to return a single string, so that
...
it can be passed as a second argument to table.insert().
2012-09-08 23:53:28 +01:00
Tigran Aivazian
e2a3f1de64
Multi-level TOC support, see issue #235 on github.
2012-09-08 23:52:04 +01:00
Tigran Aivazian
e824fb24da
Correct the comment (the existing text was referring to a different file).
2012-09-08 22:21:26 +01:00
{Qingping,Dave} Hou
aa93a8f078
Merge pull request #254 from dpavlin/master
...
fallback to default fonts when loading reader configuration
2012-09-07 08:38:37 -07:00
Dobrica Pavlinusic
406f3d72da
fallback to default fonts when loading reader configuration
...
Since we are adding and renaming fonts, we need to make sure that
all fonts which reader uses are defined. This allows us to add fonts
and not break when users load old configuration files
close #252
2012-09-07 16:29:52 +02:00
NuPogodi
a5496b83c6
Update helppage.lua
...
Fixed crash of heplpage 'cause of typo: tfont > tface
2012-09-07 15:36:38 +02:00