Commit Graph

10703 Commits

Author SHA1 Message Date
weijiuqiao
33525a80a0 VocabBuilder.koplugin: better handling of word context (#12469)
Closes #12465.
2024-09-14 14:09:49 +02:00
weijiuqiao
04aa0cbde3 CloudSync: handles potentially incompatible backup and incoming dbs (#12470)
This pr removes the backup db (sync db) of the cloud syncing strategy when a different server location is used. This is to avoid the situation when later incoming db is not based on previously uploaded sync db.
2024-09-14 14:08:03 +02:00
hius07
d3beecd3f5 ReaderAnnotation: skip old highlights with invalid xpointers (#12494) 2024-09-14 11:17:26 +03:00
NiLuJe
57ceaf3f07 SetDefaultsWidget: Don't crash on unknown custom keys
Just warn about it in the logs.
This will only show up when opening the advanced settings UI, so we'll
keep it for now instead of *also* deleting the offending kv pair,
for the sake of not randomly destroying user content...
2024-09-11 13:20:39 +02:00
NiLuJe
89cceee9f1 Defaults: Deprecate DKOPTREADER_CONFIG_DOC_LANGS_TEXT
It's unused since #11977, dropping it ensures we no longer show it in
the advanced settings UI.
2024-09-11 13:20:39 +02:00
Benoit Pierre
7ff40a3412 bump base (#12503)
- https://github.com/koreader/koreader-base/pull/1921
- https://github.com/koreader/koreader-base/pull/1922
- https://github.com/koreader/koreader-base/pull/1923
- https://github.com/koreader/koreader-base/pull/1924
- https://github.com/koreader/koreader-base/pull/1926
- https://github.com/koreader/koreader-base/pull/1927
- https://github.com/koreader/koreader-base/pull/1928
- https://github.com/koreader/koreader-base/pull/1930
- https://github.com/koreader/koreader-base/pull/1931

Close #12462, #12473.
2024-09-10 18:36:08 +02:00
cccslater
94c57b9f42 [NT] Call GotoViewRel for page up/down on useDPadAsActionKeys devices (#12495)
Page buttons call `GotoViewRel` again (not `GotoPosRel`). Fixes https://github.com/koreader/koreader/issues/12380
2024-09-09 21:17:48 +02:00
David
5b2cc5f632 Doc: Update quickstartguide on kindle non touch (#12426) 2024-09-09 14:40:17 +02:00
David
adbf3be6ec [Dispatcher] new events for selecting links (#12474) 2024-09-07 20:53:14 +02:00
hius07
5476301034 ButtonDialogTitle: remove (#12394) 2024-09-07 20:11:35 +03:00
hius07
7572a812cc Highlights popup dialog: add "Color" and "Details" buttons (#12461) 2024-09-07 17:56:40 +03:00
NiLuJe
ffc4929504 ReaderHighlight: Fix an old typo in the OCR help string (#12479)
Noticed while triaging #12478 ;)
2024-09-07 16:23:56 +02:00
NiLuJe
f8df76e5c4 misc: Move cleanupSelectedText to util (#12477)
Instead of duplicating it across ReaderHighlight, languagesupport, and potentially VocabBuilder.

Re: #12469
2024-09-06 23:06:28 +02:00
NiLuJe
8f5215abfd ReaderView: Fix a couple of edge-cases in onReaderFooterVisibilityChange (#12466)
Namely, it trips a `recalculate` that snaps `visible_area` to `page_area` edges (depending on zoom/reading direction), while we do *NOT* actually want to move the view, just increase/decrease its height ;).

(This *might* happen more reliably than it used to since https://github.com/koreader/koreader/pull/11425 & https://github.com/koreader/koreader/pull/11557)

Also deal with scroll mode while I'm here, as recalculate doesn't affect scroll mode at all, since that uses an *array* of on-screen pages, each with their own visible_area, page_area & state.

Fix #12454
2024-09-06 15:28:35 +02:00
David
802a906870 [Dispatcher] add [missing] conditions to dispatcher items (#12453)
* add [missing] conditions to dispatcher items

* add book map to NT supported devices
2024-09-05 20:07:35 +02:00
Ichnilatis
00984ba6bc Keyboard: update el_popup.lua (#12463)
Some minor changes for consistency.
2024-09-04 15:31:30 +02:00
NiLuJe
ae5222b97a InputText: Unbreak onTapTextBox on an already in-focus field (#12449)
The drive-by fix for the original issue noticed late in #12361 turned out to be a bit heavy-handed ;).

Fix #12444
Regression since #12361
2024-09-02 23:38:57 +02:00
poire-z
824bb98407 bump base: blitbuffer, android build, crengine (#12451)
Includes:
- BlitBuffer: Don't crash on nil input in colorFromName
- android: fix 32bits builds
- android: don't bother linking with `origin.ldflags`
- android: don't version shared objects
- cre.cpp: fix findAllText() context at end of book
- bump crengine: fix xml parser regression (infinite loop)
2024-09-02 23:03:35 +02:00
bitterlox
491e24ea25 Fix Joplin export (#12446)
turn highlight & notes table into string before sending to joplin
2024-09-02 10:53:07 +02:00
jonnyl2
2a9fe6fdcf Dispatcher/DeviceListener: temporarily turn on Accelerometer/GSensor for 5 sec (#12419) 2024-09-01 23:53:51 +02:00
mbays
d097dc0f8c Terminal: Add newline when wrapping
Required to maintain "tty-matrix".
2024-08-31 23:38:37 +02:00
mbays
c2dbd7bf88 Terminal: Don't refresh while input widget closed
Fixes crash on e.g. closing widget after "sleep 3 && echo -e '\eY11'"
2024-08-31 23:38:37 +02:00
mbays
2a39bd15b3 Terminal: Add FIXMEs 2024-08-31 23:38:37 +02:00
mbays
f6ee0aed4f Terminal: Ignore rightChar at end of line 2024-08-31 23:38:37 +02:00
mbays
40034743ad Terminal: Fix handling of '\b' 2024-08-31 23:38:37 +02:00
mbays
f86482c210 Terminal: Remove unnecessary expensive textbox re-inits 2024-08-31 23:38:37 +02:00
mbays
ffd75eb8f1 Terminal: Remove delay on enter 2024-08-31 23:38:37 +02:00
mbays
381a87f9f3 Terminal: Refactor to reduce algorithmic complexity 2024-08-31 23:38:37 +02:00
mbays
1ae38ea8bd Terminal: Ignore ctrl on chars less than '@'
Previous behaviour was to crash.
2024-08-31 23:38:37 +02:00
NiLuJe
cf83dc8bd3 ReaderView: Don't crash on pre-#11044 highlights without a color field (#12438)
(They'll be drawn in gray, as before)

Regression since #11044
(https://github.com/koreader/koreader/pull/11044#issuecomment-2322820971)
2024-08-31 22:55:59 +02:00
hius07
49e885321a Exporter: choose highlight styles to be exported (#12431) 2024-08-31 19:28:48 +03:00
hius07
38c8d66b5b readerhighlight: fix showing anchored popup dialog 2024-08-31 15:18:18 +02:00
hius07
6f7277d269 readersearch: fix building findall result 2024-08-31 15:18:18 +02:00
hius07
963aa9ac7c filemanagerhistory: fix update list after deleting a file 2024-08-31 15:18:18 +02:00
hius07
ee5a4169d1 webdavapi: fix 'resourcetype' property check 2024-08-31 15:18:18 +02:00
hius07
84ed68ba82 inputtext: fix deleting a word by backspace swipe north 2024-08-31 15:18:18 +02:00
Rowan Decker
60e0e3ef45 Add color highlight menu (#11044) 2024-08-30 22:10:43 +02:00
NiLuJe
89fdb5516b Bump platform/android/luajit-launcher
https://github.com/koreader/android-luajit-launcher/pull/508
https://github.com/koreader/android-luajit-launcher/pull/506
https://github.com/koreader/android-luajit-launcher/pull/510
2024-08-30 22:09:57 +02:00
NiLuJe
896d753a35 Bump base
https://github.com/koreader/koreader-base/pull/1894
https://github.com/koreader/koreader-base/pull/1908
https://github.com/koreader/koreader-base/pull/1909
https://github.com/koreader/koreader-base/pull/1904
https://github.com/koreader/koreader-base/pull/1910
https://github.com/koreader/koreader-base/pull/1911
https://github.com/koreader/koreader-base/pull/1912
https://github.com/koreader/koreader-base/pull/1901
https://github.com/koreader/koreader-base/pull/1913
https://github.com/koreader/koreader-base/pull/1680
https://github.com/koreader/koreader-base/pull/1915
https://github.com/koreader/koreader-base/pull/1916
https://github.com/koreader/koreader-base/pull/1914
2024-08-30 22:09:57 +02:00
NiLuJe
ca71bb2917 Input: Ignore ABS_X, ABS_Y & ABS_PRESSURE for snow_protocol (#12427)
On Monza, the lift frame can report these for *multiple contacts* without an id or a slot, which is super-duper invalid -_-".

(And we have ABS_MT_POSITION_X & ABS_MT_POSITION_Y for the "saner" frames, plus these devices generally don't support pens, so we don't make use of pressure).

(Also, switched to a dedicated handler like for the phoenix quirks, to avoid bogging down the standard handler with hacks for broken drivers).

Fix #11910
2024-08-30 16:04:28 +02:00
NiLuJe
a486acf48b FileManagerSetDefaults: Handle strings that we default to nil (#12433)
The actual defaults table is a hash, so we have no way of salvaging it from there without using a custom NULL type or another kind of sentinel value.
But since everything that actually *uses* the offending defaults expects a nil, don't rock the boat, and just fix the Advanced Settings widget to be able to deal with it.

Fix #11679
Regression since #9546
2024-08-30 16:02:24 +02:00
poire-z
d51179690d PageBrowser: fix drawing of thicker thumbnail frame on tap (#12432)
Bottom and right edges were not drawn since some
recent FrameContainer tweak.
2024-08-30 14:40:14 +02:00
NiLuJe
7e52c15de2 FileManager: Handle the FlushSettings event (#12425)
It's used on Android when we're murdered by the task switcher, and when doing an OTA update.

Fix #12124
2024-08-29 11:28:16 +02:00
NiLuJe
5fc5386e87 ReadTimer: Don't blindly repaint the footer in update_status_bars
Send a dedicated event that will let ReaderFooter check if we actually have anything relevant to display, and will do the usual "should I repaint/refresh" checks ;).

Fix #12323
Regression since #12002
2024-08-28 23:53:38 +02:00
NiLuJe
a86271b8f1 ReaderFooter: Use maybeUpdateFooter in onBookMetadataChanged
I'm not sure that one could ever have been truly problematic, but let's
be cautious ;).
2024-08-28 23:53:38 +02:00
jonnyl2
f3005906d4 Readerfont: current font on top in menu; new fonts from current session on top in font test doc (#12410)
* Move down call setupFaceMenuTable(); list current font on top in menu if sorted by recently selected.

* New fonts from current session listed on top in fonts test documents; small wording changes
2024-08-26 22:51:29 +02:00
Benoit Pierre
6e7b09cd3c kodev: fix ./kodev run android… (#12407)
Need to install the NDK / SDK when not configured.

Close #12404.
2024-08-26 15:35:39 +02:00
Benoit Pierre
070d591483 kodev: improve kodev prompt
Automatically use rlwrap if available.
2024-08-26 13:06:46 +02:00
Benoit Pierre
342fc850ad make: add RWRAP parameters to all emulator run rules
Useful to run those command under a debugger, valgrind, or rlwrap.
2024-08-26 13:06:46 +02:00
Benoit Pierre
6e7ccf2320 android: add custom adb logcat formatter (#12385)
- standalone: no other dependencies than Python (>= 3.7) and adb
  (Android >= 4.3 [Jelly Bean])
- filter KOReader's traces, and other processes chatter about KOReader
  (e.g. mentions of its application ID or PID)
- show time, PID, TID (when different), tag, priority, and message
- only parse the log (don't rely on `adb shell` commands)
- can be used as a filter, including on its own (uncolored) output
- we can simplify instructions to users when asking for detailed logs

Why not use pidcat?
- project is unmaintained
- does not support Python 3 (need at least one extra patch)
- mangle long lines by wrapping them, even when not outputting to a terminal,
  which is a big no-no, IMHO (as it break searching, copy pasting, etc…)
2024-08-25 23:41:25 +02:00