renun/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-08-10 00:52:20 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(msi): don't override custom ini config (#3836)
Some checks are pending
Pipeline: Test, Lint, Build / Get version info (push) Waiting to run
Details
Pipeline: Test, Lint, Build / Lint Go code (push) Waiting to run
Details
Pipeline: Test, Lint, Build / Test Go code (push) Waiting to run
Details
Pipeline: Test, Lint, Build / Test JS code (push) Waiting to run
Details
Pipeline: Test, Lint, Build / Lint i18n files (push) Waiting to run
Details
Pipeline: Test, Lint, Build / Check Docker configuration (push) Waiting to run
Details
Pipeline: Test, Lint, Build / Build (darwin/amd64) (push) Blocked by required conditions
Details
Pipeline: Test, Lint, Build / Build (darwin/arm64) (push) Blocked by required conditions
Details
Pipeline: Test, Lint, Build / Build (linux/386) (push) Blocked by required conditions
Details
Pipeline: Test, Lint, Build / Build (linux/amd64) (push) Blocked by required conditions
Details
Pipeline: Test, Lint, Build / Build (linux/arm/v5) (push) Blocked by required conditions
Details
Pipeline: Test, Lint, Build / Build (linux/arm/v6) (push) Blocked by required conditions
Details
Pipeline: Test, Lint, Build / Build (linux/arm/v7) (push) Blocked by required conditions
Details
Pipeline: Test, Lint, Build / Build (linux/arm64) (push) Blocked by required conditions
Details
Pipeline: Test, Lint, Build / Build (windows/386) (push) Blocked by required conditions
Details
Pipeline: Test, Lint, Build / Build (windows/amd64) (push) Blocked by required conditions
Details
Pipeline: Test, Lint, Build / Push Docker manifest (push) Blocked by required conditions
Details
Pipeline: Test, Lint, Build / Build Windows installers (push) Blocked by required conditions
Details
Pipeline: Test, Lint, Build / Package/Release (push) Blocked by required conditions
Details
Pipeline: Test, Lint, Build / Upload Linux PKG (push) Blocked by required conditions
Details

Browse Source 
Previously addLine would add-or-update, resulting in the custom settings being overriden on upgrade. createLine will only add to the ini if the key doesn't already exist.
This commit is contained in:
Rob Emery
2025-03-18 22:23:04 +00:00
committed by GitHub
parent e457f21306
commit 1ed8930107
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
release/wix/navidrome.wxs
View File

@@ -43,9 +43,9 @@
<Component Id="Configuration" Guid="9e17ed4b-ef13-44bf-a605-ed4132cff7f6" Win64="$(var.Win64)">
<IniFile Id="ConfigurationPort" Name="navidrome.ini" Action="createLine" Directory="INSTALLDIR" Key="Port" Section="default" Value="&apos;[ND_PORT]&apos;" />
<IniFile Id="ConfigurationMusicDir" Name="navidrome.ini" Action="addLine" Directory="INSTALLDIR" Key="MusicFolder" Section="default" Value="&apos;[ND_MUSICFOLDER]&apos;" />
<IniFile Id="ConfigurationDataDir" Name="navidrome.ini" Action="addLine" Directory="INSTALLDIR" Key="DataFolder" Section="default" Value="&apos;[ND_DATAFOLDER]&apos;" />
<IniFile Id="FFmpegPath" Name="navidrome.ini" Action="addLine" Directory="INSTALLDIR" Key="FFmpegPath" Section="default" Value="&apos;[INSTALLDIR]ffmpeg.exe&apos;" />
<IniFile Id="ConfigurationMusicDir" Name="navidrome.ini" Action="createLine" Directory="INSTALLDIR" Key="MusicFolder" Section="default" Value="&apos;[ND_MUSICFOLDER]&apos;" />
<IniFile Id="ConfigurationDataDir" Name="navidrome.ini" Action="createLine" Directory="INSTALLDIR" Key="DataFolder" Section="default" Value="&apos;[ND_DATAFOLDER]&apos;" />
<IniFile Id="FFmpegPath" Name="navidrome.ini" Action="createLine" Directory="INSTALLDIR" Key="FFmpegPath" Section="default" Value="&apos;[INSTALLDIR]ffmpeg.exe&apos;" />
</Component>
<Component Id='MainExecutable' Guid='e645aa06-8bbc-40d6-8d3c-73b4f5b76fd7' Win64="$(var.Win64)">