2.6.2

manifest-beta.json

@@ -1,7 +1,7 @@
 {
 	"id": "obsidian-excalidraw-plugin",
 	"name": "Excalidraw",
-	"version": "2.6.0",
+	"version": "2.6.2",
 	"minAppVersion": "1.1.6",
 	"description": "An Obsidian plugin to edit and view Excalidraw drawings",
 	"author": "Zsolt Viczian",

manifest.json

@@ -1,7 +1,7 @@
 {
   "id": "obsidian-excalidraw-plugin",
   "name": "Excalidraw",
-  "version": "2.6.0",
+  "version": "2.6.2",
   "minAppVersion": "1.1.6",
   "description": "An Obsidian plugin to edit and view Excalidraw drawings",
   "author": "Zsolt Viczian",

package.json

@@ -19,7 +19,7 @@
   "license": "MIT",
   "dependencies": {
     "@popperjs/core": "^2.11.8",
-    "@zsviczian/excalidraw": "0.17.6-7",
+    "@zsviczian/excalidraw": "0.17.6-8",
     "chroma-js": "^2.4.2",
     "clsx": "^2.0.0",
     "@zsviczian/colormaster": "^1.2.2",

src/EmbeddedFileLoader.ts

@@ -1106,8 +1106,48 @@ export class EmbeddedFilesLoader {
 }
 
 const getSVGData = async (app: App, file: TFile, colorMap: ColorMap | null): Promise<DataURL> => {
-  const svg = replaceSVGColors(await app.vault.read(file), colorMap) as string;
-  return svgToBase64(svg) as DataURL;
+  const svgString = replaceSVGColors(await app.vault.read(file), colorMap) as string;
+
+  try {
+    const container = document.createElement('div');
+    container.innerHTML = svgString;
+    
+    const svgElement = container.querySelector('svg');
+    
+    if (!svgElement) {
+      throw new Error('Invalid SVG content'); // Ensure there's an SVG element
+    }
+
+    // Check for width and height attributes
+    const hasWidth = svgElement.hasAttribute('width');
+    const hasHeight = svgElement.hasAttribute('height');
+
+    // If width or height is missing, calculate based on viewBox
+    if (!hasWidth || !hasHeight) {
+      const viewBox = svgElement.getAttribute('viewBox');
+      
+      if (viewBox) {
+        const [ , , viewBoxWidth, viewBoxHeight] = viewBox.split(/\s+/).map(Number);
+
+        // Set width and height based on viewBox if they are missing
+        if (!hasWidth) {
+          svgElement.setAttribute('width', `${viewBoxWidth}px`);
+        }
+        if (!hasHeight) {
+          svgElement.setAttribute('height', `${viewBoxHeight}px`);
+        }
+      }
+    }
+
+    // Get the updated SVG string from outerHTML
+    const updatedSVGString = svgElement.outerHTML;
+
+    // Convert the updated SVG string to a base64 Data URL
+    return svgToBase64(updatedSVGString) as DataURL;
+  } catch (error) {
+    errorlog({ where: "EmbeddedFileLoader.getSVGData", error });
+    return svgToBase64(svgString) as DataURL;
+  }
 };
 
 /*export const generateIdFromFile = async (file: ArrayBuffer): Promise<FileId> => {

src/dialogs/Messages.ts

@@ -17,6 +17,19 @@ I develop this plugin as a hobby, spending my free time doing this. If you find
 
 <div class="ex-coffee-div"><a href="https://ko-fi.com/zsolt"><img src="https://storage.ko-fi.com/cdn/kofi6.png?v=6" border="0" alt="Buy Me a Coffee at ko-fi.com"  height=45></a></div>
 `,
+"2.6.2":`
+## Fixed
+- Image scaling issue with SVGs that miss the width and height property. [#8729](https://github.com/excalidraw/excalidraw/issues/8729)
+`,
+"2.6.1":`
+## New
+- Pen-mode single-finger panning enabled also for the "Selection" tool.
+- You can disable pen-mode single-finger panning in Plugin Settings under Excalidraw Appearance and Behavior [#2080](https://github.com/zsviczian/obsidian-excalidraw-plugin/issues/2080)
+
+## Fixed
+- Text tool did not work in pen-mode using finger [#2080](https://github.com/zsviczian/obsidian-excalidraw-plugin/issues/2080)
+- Pasting images to Excalidraw from the web resulted in filenames of "image_1.png", "image_2.png" instead of "Pasted Image TIMESTAMP" [#2081](https://github.com/zsviczian/obsidian-excalidraw-plugin/issues/2081)
+`,
 "2.6.0":`
 ## Performance
 - Much faster plugin initialization. Down from 1000-3000ms to 100-300ms. According to my testing speed varies on a wide spectrum depending on device, size of Vault and other plugins being loaded. I measured values ranging from 84ms up to 782ms [#2068](https://github.com/zsviczian/obsidian-excalidraw-plugin/issues/2068)

src/lang/locale/en.ts

@@ -355,6 +355,7 @@ FILENAME_HEAD: "Filename",
   DEFAULT_PEN_MODE_DESC:
     "Should pen mode be automatically enabled when opening Excalidraw?",
   DISABLE_DOUBLE_TAP_ERASER_NAME: "Enable double-tap eraser in pen mode",
+  DISABLE_SINGLE_FINGER_PANNING_NAME: "Enable single-finger panning in pen mode",
   SHOW_PEN_MODE_FREEDRAW_CROSSHAIR_NAME: "Show (+) crosshair in pen mode",
   SHOW_PEN_MODE_FREEDRAW_CROSSHAIR_DESC:
     "Show crosshair in pen mode when using the freedraw tool. <b><u>Toggle ON:</u></b> SHOW <b><u>Toggle OFF:</u></b> HIDE<br>"+

src/settings.ts

@@ -85,6 +85,7 @@ export interface ExcalidrawSettings {
   defaultMode: string;
   defaultPenMode: "never" | "mobile" | "always";
   penModeDoubleTapEraser: boolean;
+  penModeSingleFingerPanning: boolean;
   penModeCrosshairVisible: boolean;
   renderImageInMarkdownReadingMode: boolean,
   renderImageInHoverPreviewForMDNotes: boolean,
@@ -261,6 +262,7 @@ export const DEFAULT_SETTINGS: ExcalidrawSettings = {
   defaultMode: "normal",
   defaultPenMode: "never",
   penModeDoubleTapEraser: true,
+  penModeSingleFingerPanning: true,
   penModeCrosshairVisible: true,
   renderImageInMarkdownReadingMode: false,
   renderImageInHoverPreviewForMDNotes: false,
@@ -1066,6 +1068,17 @@ export class ExcalidrawSettingTab extends PluginSettingTab {
             this.applySettingsUpdate();
           }),
       );
+    
+    new Setting(detailsEl)
+      .setName(t("DISABLE_SINGLE_FINGER_PANNING_NAME"))
+      .addToggle((toggle) =>
+        toggle
+          .setValue(this.plugin.settings.penModeSingleFingerPanning)
+          .onChange(async (value) => {
+            this.plugin.settings.penModeSingleFingerPanning = value;
+            this.applySettingsUpdate();
+          }),
+      );
 
     new Setting(detailsEl)
       .setName(t("SHOW_PEN_MODE_FREEDRAW_CROSSHAIR_NAME"))

src/utils/PDFUtils.ts

@@ -0,0 +1,27 @@
+//for future use, not used currently
+
+import { ImageCrop } from "@zsviczian/excalidraw/types/excalidraw/element/types";
+import { LinkParts } from "./Utils";
+
+export function getPDFCropRect (props: {
+  scale: number,
+  linkParts: LinkParts, 
+  naturalHeight: number, 
+  naturalWidth: number,
+}) : ImageCrop | null {
+  const cropRect = props.linkParts.ref.split("rect=")[1]?.split(",").map(x=>parseInt(x));
+  const validRect = cropRect && cropRect.length === 4 && cropRect.every(x=>!isNaN(x));
+
+  if(!validRect) {
+    return null;
+  }
+
+  return {
+    x: cropRect[0] * props.scale,
+    y: (props.naturalHeight/props.scale - cropRect[3]) * props.scale,
+    width: (cropRect[2] - cropRect[0]) * props.scale,
+    height: (cropRect[3] - cropRect[1]) * props.scale,
+    naturalWidth: props.naturalWidth,
+    naturalHeight: props.naturalHeight,
+  }
+}