renun/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire synced 2025-08-12 06:26:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

💩 Moves viewDidLoad function to viewWillAppear

Browse Source 
These functions, when called from viewDidLoad, were resulting in memory errors:

error: Trying to put the stack in unreadable memory at: 0x16f0efc00.
This commit is contained in:
Stuart Breckenridge
2025-06-13 14:31:15 +08:00
parent 2695a22d67
commit d774e53647
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
iOS/MainFeed/MainFeedViewController.swift
View File

@@ -50,22 +50,17 @@ class MainFeedViewController: UITableViewController, UndoableCommandRunner {
override func viewDidLoad() {
super.viewDidLoad()
if traitCollection.userInterfaceIdiom == .phone {
navigationController?.navigationBar.prefersLargeTitles = true
}
// If you don't have an empty table header, UIKit tries to help out by putting one in for you
// that makes a gap between the first section header and the navigation bar
var frame = CGRect.zero
frame.size.height = .leastNormalMagnitude
tableView.tableHeaderView = UIView(frame: frame)
// var frame = CGRect.zero
// frame.size.height = .leastNormalMagnitude
// tableView.tableHeaderView = UIView(frame: frame)
tableView.register(MainFeedTableViewSectionHeader.self, forHeaderFooterViewReuseIdentifier: "SectionHeader")
tableView.dragDelegate = self
tableView.dropDelegate = self
tableView.dragInteractionEnabled = true
resetEstimatedRowHeight()
tableView.separatorStyle = .none
NotificationCenter.default.addObserver(self, selector: #selector(unreadCountDidChange(_:)), name: .UnreadCountDidChange, object: nil)
@@ -85,10 +80,7 @@ class MainFeedViewController: UITableViewController, UndoableCommandRunner {
registerForTraitChanges([UITraitPreferredContentSizeCategory.self], target: self, action: #selector(preferredContentSizeCategoryDidChange))
refreshControl = UIRefreshControl()
refreshControl!.addTarget(self, action: #selector(refreshAccounts(_:)), for: .valueChanged)
configureToolbar()
becomeFirstResponder()
}
@@ -96,6 +88,14 @@ class MainFeedViewController: UITableViewController, UndoableCommandRunner {
navigationController?.isToolbarHidden = false
updateUI()
super.viewWillAppear(animated)
if traitCollection.userInterfaceIdiom == .phone {
navigationController?.navigationBar.prefersLargeTitles = true
}
resetEstimatedRowHeight()
refreshControl = UIRefreshControl()
refreshControl!.addTarget(self, action: #selector(refreshAccounts(_:)), for: .valueChanged)
configureToolbar()
}
// MARK: Notifications