renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[UX] Inform about hold to set custom DPI, up DPI limit to 900 (#4388)

Browse Source 
* It was unclear that you needed to hold to set DPI, see https://github.com/koreader/koreader/issues/2589#issuecomment-445471384

* Up the DPI limit to 900 as several Android devices have already breached 800. This will increase the possibility of crashes due to a higher setting even on relatively high-DPI devices, but that was always already an issue.

* Also brings the custom DPI dialog box in line with the UX guidelines as per <http://koreader.rocks/doc/modules/ui.widget.confirmbox.html>.
This commit is contained in:
Frans de Jonge
2018-12-08 17:11:55 +00:00
committed by GitHub
parent 0a63ee5a11
commit e8192c8a04
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
frontend/ui/elements/screen_dpi_menu_table.lua
View File

@@ -1,5 +1,6 @@
local _ = require("gettext")
local Screen = require("device").screen
local T = require("ffi/util").template
local function dpi() return G_reader_settings:readSetting("screen_dpi") end
@@ -10,7 +11,7 @@ local function setDPI(_dpi)
local InfoMessage = require("ui/widget/infomessage")
local UIManager = require("ui/uimanager")
UIManager:show(InfoMessage:new{
text = _("This will take effect on next restart."),
text = _("This will take effect after restarting."),
})
Screen:setDPI(_dpi)
end
@@ -51,23 +52,24 @@ return {
callback = function() setDPI(240) end
},
{
text = _("Custom DPI") .. ": " .. (custom() or 160),
text = T(_("Custom DPI: %1 (hold to set)"), custom() or 160),
checked_func = function()
local _dpi, _custom = dpi(), custom()
return _custom and _dpi == _custom
end,
callback = function() setDPI(custom() or 160) end,
hold_input = {
title = _("Input screen DPI"),
title = _("Enter custom screen DPI"),
type = "number",
hint = "(90 - 600)",
hint = "(90 - 900)",
callback = function(input)
local _dpi = tonumber(input)
_dpi = _dpi < 90 and 90 or _dpi
_dpi = _dpi > 600 and 600 or _dpi
_dpi = _dpi > 900 and 900 or _dpi
G_reader_settings:saveSetting("custom_screen_dpi", _dpi)
setDPI(_dpi)
end,
ok_text = _("Set custom DPI"),
},
},
}