renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ReaderHighlight, ReaderBookmark: Highlight button labels, Bookmark details button order (#13735)
Some checks failed
macos / macOS 13 x86-64 🔨15.2 🎯10.15 (push) Has been cancelled
Details
macos / macOS 14 ARM64 🔨15.4 🎯11.0 (push) Has been cancelled
Details

Browse Source 
* Add Xs to highlight erase buttons

* Change order of buttons
This commit is contained in:
jonnyl2
2025-05-05 19:57:04 +00:00
committed by GitHub
parent a60cf6b108
commit fce94ce1de
2 changed files with 33 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
frontend/apps/reader/modules/readerbookmark.lua
View File

@@ -1176,6 +1176,36 @@ function ReaderBookmark:showBookmarkDetails(item_or_index)
end
local buttons_table = {
{
{
text = "▕◁",
enabled = item_idx > 1,
callback = function()
_showBookmarkDetails(1)
end,
},
{
text = "◁",
enabled = item_idx > 1,
callback = function()
_showBookmarkDetails(item_idx - 1)
end,
},
{
text = "▷",
enabled = item_idx < items_nb,
callback = function()
_showBookmarkDetails(item_idx + 1)
end,
},
{
text = "▷▏",
enabled = item_idx < items_nb,
callback = function()
_showBookmarkDetails(items_nb)
end,
},
},
{
{
text = _("Reset text"),
@@ -1220,12 +1250,6 @@ function ReaderBookmark:showBookmarkDetails(item_or_index)
},
},
{
{
text = _("Close"),
callback = function()
textviewer:onClose()
end,
},
{
text = _("Go to bookmark"),
enabled = not (bm_menu and bm_menu.select_count),
@@ -1236,34 +1260,10 @@ function ReaderBookmark:showBookmarkDetails(item_or_index)
end
end,
},
},
{
{
text = "▕◁",
enabled = item_idx > 1,
text = _("Close"),
callback = function()
_showBookmarkDetails(1)
end,
},
{
text = "◁",
enabled = item_idx > 1,
callback = function()
_showBookmarkDetails(item_idx - 1)
end,
},
{
text = "▷",
enabled = item_idx < items_nb,
callback = function()
_showBookmarkDetails(item_idx + 1)
end,
},
{
text = "▷▏",
enabled = item_idx < items_nb,
callback = function()
_showBookmarkDetails(items_nb)
textviewer:onClose()
end,
},
},

2
frontend/apps/reader/modules/readerhighlight.lua
View File

@@ -1373,7 +1373,7 @@ end
function ReaderHighlight:showHighlightDialog(index)
local item = self.ui.annotation.annotations[index]
local change_boundaries_enabled = not item.text_edited
local start_prev, start_next, end_prev, end_next = "◁▒▒", "▷▒▒", "▒▒◁", "▒▒▷"
local start_prev, start_next, end_prev, end_next = "◁▒▒", "▷☓▒", "▒☓◁", "▒▒▷"
if BD.mirroredUILayout() then
-- BiDi will mirror the arrows, and this just works
start_prev, start_next = start_next, start_prev