Commit Graph

7156 Commits

Author SHA1 Message Date
poire-z
4740ab1fdc bump crengine: round FT metrics, split text drawing by script (#5628)
Includes:
- Fonts: round FT metrics instead of floor'ing them
- Fonts: switch to no hinting when native hinting fails
- Fonts: fix issue with Harfbuzz fallback font drawing
- Text: split measuring and word drawing by unicode script
- Page splitting: fix small memory leak
- Fix "background-color: black" ignored on inline elements
- Fix decoding of recent MOBI files
- Hardcoded elements list: add <font>
base/xtext.cpp: small cleanup, no logic change
2019-11-22 23:54:34 +01:00
NiLuJe
e0f14a336e Rewrite unicodeCodepointToUtf8 w/ bitopt (#5625)
* Rewrite unicodeCodepointToUtf8 w/ bitopt

Avoids costly divs & modulos
2019-11-22 19:50:58 +01:00
Frans de Jonge
da5f3c0d53 Bump base (#5623)
* [chore] thirdparty patch file dependencies https://github.com/koreader/koreader-base/pull/1012
* Revert "[fix] MuPDF Android font dir patch update https://github.com/koreader/koreader-base/pull/1013

Fixes #5617.
2019-11-21 15:11:25 +01:00
yparitcher
6d3e7fcef6 [fix] PDF footer margins (#5620)
closes #5612 

the change in `ReaderView:recalculate()` causes the viewable page size to be calculated by not including the footer, causing the text not to get cut off.

since the page area was not drawing under the footer `ReaderView:drawPageSurround()` had to be fixed to draw the margin under the footer so when tapping the footer off the area should be dran the background color.
2019-11-21 10:05:40 +01:00
Robert
03fda96041 [fix] Empty directory path and crash on TextWidget (#5606) 2019-11-19 21:06:03 +01:00
Frans de Jonge
7775233688 [fix] Prevent xtext crash by not freeing TextWidget prematurely (#5616)
Fixes <https://github.com/koreader/koreader/issues/5614>.
2019-11-19 17:21:42 +01:00
Robert
e655616876 Cloud storage UX improvements (#5613)
* Overwrite confirmbox order

* Restore confirmbox option to read the downloaded book
2019-11-19 16:52:11 +01:00
Frans de Jonge
15fe0fef07 [chore] Extract Cyrillic/Russian keyboard (#5610)
Follow-up to #5583.

* Add separate Cyrillic/Russian keyboard

* And remove that from English

* Update French keyboard (is easy)

* Remove yahzhert, that was just a double of QWERTY

* Update Spanish keyboard

* Reduce Japanese to 4 layers and add globe

* Reduce Korean to 4 layers

* Reduce Greek to 8 layers
2019-11-18 23:33:22 +01:00
Frans de Jonge
67b57834da [lang] Minor touchups (#5611) 2019-11-18 20:51:08 +01:00
Robert
04741d8cfd [feat] Synchronize local folder with dropbox (#5591)
Option to synchronize files in local koreader folder with folder on Dropbox. All files that aren't on the local disk will be downloaded. Files with different sizes will also be downloaded and overwritten.
The download process can be paused or stopped at any time (similar to downloading images in Wikipedia).

Synchronize and settings are available after long press in dropbox account in Cloud storage.
Limitations: Only one folder (without subfolders) can be synchronize with one folder on local storage.
2019-11-18 18:39:45 +01:00
Frans de Jonge
16fd731f73 [doc] Add coreutils to Mac brew dependencies (#5608)
See 75d02a9038 (commitcomment-36008019)
2019-11-18 17:55:40 +01:00
yparitcher
5e8d1227ef [feat, UX] Pick keyboard layout from keyboard (#5583)
* Tap goes to next activated keyboard.
* Hold opens a selection popup.
2019-11-18 17:16:06 +01:00
Frans de Jonge
afd277901a [fix] Prevent double library loads (#5607)
As per @NiLuJe's suggestions from <https://github.com/koreader/koreader/pull/5598#issuecomment-554767891>.

I'm not super happy with this but being able to easily run the emulator is the most important thing.
2019-11-18 15:24:44 +01:00
Frans de Jonge
50878eab9e [fix] Tailor plurals match (#5603)
Fixes #5601.
2019-11-18 12:41:22 +01:00
poire-z
9d2da98247 bump xtext: link against stdc++ (#5605) 2019-11-17 23:02:18 +01:00
poire-z
89c0bd0886 ConfigDialog: allow larger toggle title text
Avoid a few truncated text, as some fit when allowed
to bite a bit on the (large) left padding.
2019-11-16 23:39:01 +01:00
poire-z
558bd1ebeb cre fonts list: ignore nerdfonts/symbol.ttf
It's rejected anyway by crengine, this just avoids
an error from being logged.
2019-11-16 23:39:01 +01:00
poire-z
dc8696bd34 TextBoxWidget: add new properties, use them in Menu
- height_adjust: if true, reduce height to a multiple of
  line_height (for nicer centering)
- height_overflow_show_ellipsis: if height overflow, append
  ellipsis to last shown line
(Implemented in both use_xtext and legacy code path.)

Use them in Menu.lua to clean up/shorten the code used for multiline
menu items by delegating the work to TextBoxWidget, or using
TextWidget when we end up needing only a single line.
2019-11-16 18:41:14 +01:00
poire-z
e699a1ee22 TextBoxWidget: use xtext for text shaping
Alternative code to size, split lines and draw text with
the help of the xtext Lua C module.
Enabled by default (can be disabled via an added menu
item in "Developer options").

New properties can be specified by calling widgets, only
used when xtext is used:
- lang: use specified language instead of the UI language
- para_direction_rtl: true/false to override the default
  direction for the UI language
- auto_para_direction: detect direction of each paragraph
  in text
- alignment_strict: prevent the inversion of the specified
  alignment= that is done when a paragraph direction is
  set or detected as RTL.

Also: fix possible memory leak (present even when not using xtext)
by calling :free() in onCloseWidget() like it's done in ImageWidget.
2019-11-16 18:41:14 +01:00
poire-z
22e3e34c45 TextWidget: use xtext for text shaping
Alternative code to size and draw text with the help
of the xtext Lua C module.
Enabled by default (can be disabled via an added menu
item in "Developer options").

New properties can be specified by calling widgets, only
used when xtext is used:
- lang: use specified language instead of the UI language
- para_direction_rtl: true/false to override the default
  direction for the UI language
- auto_para_direction: detect direction of each paragraph
  in text
2019-11-16 18:41:14 +01:00
poire-z
c2e2c00db6 Font rendering: add some helpers for use by xtext
bump base for libkoreader-xtext.so:
- ffi/pic.lua: fix memory leak with some unsupported PNG files
- FreeType ffi: add methods for use with Harfbuzz shaping
- thirdparty: adds libunibreak
- Adds libkoreader-xtext.so: enhanced text shaping

Add a getFallbackFont(N) to each Lua font object to instantiate
(if not yet done) and return the Nth fallback font for the font.

Fallback fonts list: add NotoSansArabicUI-Regular.ttf

Add RenderText:getGlyphByIndex() to get a glyph bitmap by glyph
index, which is what we'll get from Harfbuzz shaping.
(RenderText:getGlyph() works with unicode charcode).
2019-11-16 18:41:14 +01:00
poire-z
272d8857a2 TextBoxWidget: fix two minor bugs 2019-11-16 18:41:14 +01:00
poire-z
0fb780ea21 PicDocument: log reason of opening failure 2019-11-16 18:41:14 +01:00
Robert
679b592c80 [UX] Add Mark as read to end of document action (#5596) 2019-11-16 14:51:21 +01:00
NiLuJe
b21b4c8776 Update nerdfonts symbol codepoints for the updated version with no PUA (#5595)
* Update nerdfonts symbol codepoints for the updated version with no PUA conflicts

Should no longer stomp on Arabic & CJK PUA stuff.
2019-11-15 19:06:35 +01:00
Robert
e166a77eba [UX] Gesture to open Favorites (#5592)
Close: #5576 
+ default multigesture east - west - east -> open `Favorites`,
+ ability to add new gesture to open `Favorites`
2019-11-14 15:00:05 +01:00
Frans de Jonge
2855fdfdac [feat] Support callback function in VirtualKeyPopup (#5588)
Required for <https://github.com/koreader/koreader/pull/5583>.
2019-11-11 23:10:27 +01:00
Frans de Jonge
35154b8d56 Bump base for [fix] Prevent undefined symbol error on SDL < 2.0.9 (#5587)
Fixes https://github.com/koreader/koreader/issues/5570 for real this time. ;-)
v2019.11
2019-11-11 16:57:41 +01:00
Frans de Jonge
3550672a5e Bump base (#5586)
Includes:

* [fix] LuaRocks 2 and 3 compat (#1004)
* [fix] Revert Android Noto patch (#1007)
* [fix] Don't crash on SDL < 2.9 (#1008)
2019-11-11 15:14:46 +01:00
Frans de Jonge
425c808c18 [UX] Switch ButtonTable to COLOR_GRAY (#5585)
Same as the menu.

See <https://github.com/koreader/koreader/pull/5584>.
2019-11-11 10:05:28 +01:00
yparitcher
816b197ab9 [UX] Thicker loading bar (#5581)
The current thickness for the loading bar when opening a document is to thin to really see on my KT4,
2019-11-10 21:27:49 +01:00
yparitcher
83b7d8de2b [UX] Default setting option always enabled (#5580)
as per https://github.com/koreader/koreader/pull/5522#issuecomment-548006595 do not grey out the current default
2019-11-08 21:01:38 +01:00
Robert
98555908c8 [fix] Enable rewind button in sort widget (#5579)
See: #5578
Close: #5578
2019-11-08 10:26:41 +01:00
Frans de Jonge
9bc1c6f40d Add CODEOWNERS file (#5559)
A bit of an experiment with GitHub functionality.

Teams can be added like `@koreader/kobo-dev` but that doesn't seem too much use to us right now.
2019-11-07 20:39:50 +01:00
Robert
2ae91ac6f6 [fix] Prevent crash on local calibre OPDS server (#5572)
Close: #5476 
- Prevent segmentation fault when we enter incorrect address of calibre opds server (eg http://192.168.1.1:8080/ instead of proper http://192.168.1.1:8080/opds
- prevent unnecessary infos in Gutenberg OPDS
2019-11-07 20:37:02 +01:00
poire-z
0885e9947d Keyboard: avoid additional key stroke on hold release (#5573) 2019-11-06 21:26:17 +01:00
Frans de Jonge
dc4453eb7f [fix, plugin] Don't show full widget together with isOnline() (#5575)
Fixes https://github.com/koreader/koreader/issues/5415

Cf. https://github.com/koreader/koreader/pull/5452 https://github.com/koreader/koreader/pull/5573 https://github.com/koreader/koreader/pull/5574
2019-11-06 21:02:41 +01:00
Frans de Jonge
f0b2d58342 Revert "Fix frozen confirmbox when keyboard shown (#5452)" (#5574)
This reverts commit 513fd807b0.
2019-11-06 21:02:27 +01:00
Martín Fernández
f1f75c5cb0 android: touchscreen toggle option (#5564) 2019-11-06 00:52:44 +01:00
Robert
371e3336a5 [feat] Favorites: organize book into collections (#5527)
View, add, remove, sort, open book to/from collections.
For now, only one collection named Favorites.
2019-11-06 00:17:28 +01:00
poire-z
04ce1836d8 Avoid double flash when switching or reloading document (#5568) 2019-11-04 16:44:13 +01:00
poire-z
4462380048 Wikipedia lookup results: fix page turning when image loading (#5560)
Tapping to turn page while some image is loading was
interrupting the image loading, but not turning the page,
since a82d7832 where using trap_widget=false is to be
used to not resend the event (while =nil does resend it).
2019-11-02 02:30:12 +01:00
poire-z
6baa2af5fb cre: use 'best' (Harfbuzz) as the default kerning method (#5553)
It might be slower, but is needed to properly display
books in arabic, indic...
Also bump crengine: use FreeType "light" hinting algorithm,
which hints on the y-axis only (and so avoid messing with
advances and kerning on the x-axis).
2019-11-01 23:07:41 +01:00
poire-z
16c021a76a CoverBrowser: fix files_per_page setting type (#5556)
Avoid saving/getting "12.0" (as the lua-ljsqlite3 driver does),
and save/get "12" instead by properly converting it to a string
and back, as the config.value table column is of type TEXT.
2019-11-01 11:29:11 +01:00
poire-z
eb8795e4e0 ButtonTable: taller buttons for easier tap (#5554) 2019-11-01 01:52:05 +01:00
poire-z
602a821acc CoverBrowser: list mode: better default for files_per_page (#5551)
Don't use a hardcoded default value of 10 files per page, but
compute it from available height, as previously (this reverts
a bit from 0ecf42e9).
2019-10-31 12:06:21 +01:00
NiLuJe
a5419439ce Bump base (#5549)
Pickup https://github.com/koreader/koreader-base/pull/1000,
https://github.com/koreader/koreader-base/pull/1001,
https://github.com/koreader/koreader-base/pull/1002,
https://github.com/koreader/koreader-base/pull/1003
2019-10-30 01:40:24 +01:00
NiLuJe
4f52c4147f Fix a deadlock with empty settings (#5546)
* Fix deadlock on empty settings
Emulator only. Was stuck looping forever on directory == base == .
2019-10-30 00:27:54 +01:00
Frans de Jonge
34090c2f22 [fix, Android] Crash on startup when no homedir is set (#5548)
By calling the function instead of returning it. Fixes #5547.
2019-10-29 17:56:21 +01:00
NiLuJe
21c5d58685 Allow access to the topmenu clock format even if !Device:setDateTime() (#5543) 2019-10-28 22:42:07 +01:00